Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(398)

Issue 289973008: Remove Chromium plumbing for fixed-position-creates-stacking-context. (Closed)

Created:
6 years, 7 months ago by jbroman
Modified:
6 years, 7 months ago
CC:
chromium-reviews, darin-cc_chromium.org, nasko+codewatch_chromium.org, jam, jochen+watch_chromium.org, creis+watch_chromium.org
Visibility:
Public.

Description

Remove Chromium plumbing for fixed-position-creates-stacking-context This is a no-op since over a month ago: https://codereview.chromium.org/206463009/ So it's probably safe to remove the Chromium code which plumbs this preference around before Blink drops it on the floor. After this lands, WebSettings::setFixedPositionCreatesStackingContext can be removed entirely. BUG=354688 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=273045

Patch Set 1 #

Patch Set 2 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -35 lines) Patch
M build/ios/grit_whitelist.txt View 1 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/app/generated_resources.grd View 1 1 chunk +0 lines, -6 lines 0 comments Download
M chrome/browser/about_flags.cc View 1 1 chunk +0 lines, -9 lines 0 comments Download
M content/browser/renderer_host/render_view_host_impl.cc View 1 1 chunk +0 lines, -3 lines 0 comments Download
M content/public/common/common_param_traits_macros.h View 1 chunk +0 lines, -1 line 0 comments Download
M content/public/common/content_switches.h View 1 2 chunks +0 lines, -2 lines 0 comments Download
M content/public/common/content_switches.cc View 1 2 chunks +0 lines, -6 lines 0 comments Download
M content/renderer/web_preferences.cc View 1 1 chunk +0 lines, -3 lines 0 comments Download
M content/shell/common/webkit_test_helpers.cc View 1 chunk +0 lines, -1 line 0 comments Download
M webkit/common/webpreferences.h View 1 chunk +0 lines, -1 line 0 comments Download
M webkit/common/webpreferences.cc View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 18 (0 generated)
jbroman
I assume this plumbing was just forgotten after the original change? If this LGTY, I'll ...
6 years, 7 months ago (2014-05-16 20:17:38 UTC) #1
jbroman
On 2014/05/16 20:17:38, jbroman wrote: > I assume this plumbing was just forgotten after the ...
6 years, 7 months ago (2014-05-24 01:05:04 UTC) #2
jochen (gone - plz use gerrit)
lgtm
6 years, 7 months ago (2014-05-24 10:58:36 UTC) #3
jbroman
+jamesr for webkit/
6 years, 7 months ago (2014-05-26 13:31:13 UTC) #4
jamesr
lgtm
6 years, 7 months ago (2014-05-27 17:29:32 UTC) #5
jbroman
The CQ bit was checked by jbroman@chromium.org
6 years, 7 months ago (2014-05-27 17:29:54 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jbroman@chromium.org/289973008/1
6 years, 7 months ago (2014-05-27 17:31:37 UTC) #7
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: android_dbg_triggered_tests on tryserver.chromium ...
6 years, 7 months ago (2014-05-27 18:18:22 UTC) #8
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 7 months ago (2014-05-27 18:22:19 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/chromium_presubmit/builds/69910)
6 years, 7 months ago (2014-05-27 18:22:21 UTC) #10
jbroman
The CQ bit was checked by jbroman@chromium.org
6 years, 7 months ago (2014-05-27 19:54:11 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jbroman@chromium.org/289973008/20001
6 years, 7 months ago (2014-05-27 19:55:22 UTC) #12
jbroman
+dcheng for content/public/common/common_param_traits_macros.h didn't notice the 'set noparent' OWNERS before
6 years, 7 months ago (2014-05-27 20:06:36 UTC) #13
jbroman
The CQ bit was unchecked by jbroman@chromium.org
6 years, 7 months ago (2014-05-27 20:07:08 UTC) #14
dcheng
rslgtm
6 years, 7 months ago (2014-05-27 20:15:15 UTC) #15
jbroman
The CQ bit was checked by jbroman@chromium.org
6 years, 7 months ago (2014-05-27 20:22:32 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jbroman@chromium.org/289973008/20001
6 years, 7 months ago (2014-05-27 20:24:16 UTC) #17
commit-bot: I haz the power
6 years, 7 months ago (2014-05-27 21:52:53 UTC) #18
Message was sent while issue was closed.
Change committed as 273045

Powered by Google App Engine
This is Rietveld 408576698