Issue 289973006: Make skia compile in Android GN build.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 289973006: Make skia compile in Android GN build. (Closed)

Created:
6 years, 7 months ago by brettw

Modified:
6 years, 7 months ago

Reviewers:
djsollen

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Make skia compile in Android GN build. Adds a bunch of ARM configuration and assembly sources. MIPS still not done. Implements the Android Freetype build and fixes expat. Fixes some minor optimization-related flags I noticed along the way. TBR=djsollen@google.com Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=271603

Patch Set 1 #

Patch Set 2 : #

Created: 6 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+162 lines, -4 lines)			Patch
M	BUILD.gn	View	1	1 chunk	+0 lines, -1 line	0 comments	Download
M	build/config/compiler/BUILD.gn	View	1	1 chunk	+11 lines, -1 line	0 comments	Download
M	skia/BUILD.gn	View		3 chunks	+90 lines, -2 lines	0 comments	Download
M	third_party/expat/BUILD.gn	View		3 chunks	+9 lines, -0 lines	0 comments	Download
A	tools/gn/secondary/third_party/freetype/BUILD.gn	View	1	1 chunk	+52 lines, -0 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/brettw@chromium.org/289973006/20001

6 years, 7 months ago (2014-05-20 04:30:41 UTC) #3

Message was sent while issue was closed.

lgtm

Expand Messages | Collapse Messages