Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(43)

Issue 2899683003: Included setters in testing of the void => return-any-type feature. (Closed)

Created:
3 years, 7 months ago by eernst
Modified:
3 years, 7 months ago
CC:
reviews_dartlang.org, floitsch
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Included setters in testing of the void => return-any-type feature. The older issue https://github.com/dart-lang/sdk/issues/28939 did not mention setters. They were already covered in the implementation, so this CL just adds testing for it. Addresses issue https://github.com/dart-lang/sdk/issues/29680. R=floitsch@google.com, johnniwinther@google.com Committed: https://github.com/dart-lang/sdk/commit/8aef60a78f2043a51c0d36b3b809f30e10ea3ed2

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -0 lines) Patch
M tests/compiler/dart2js/type_checker_test.dart View 2 chunks +6 lines, -0 lines 0 comments Download
M tests/language/void_arrow_return_test.dart View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
eernst
Covering setters for the "return anything from =>" features turned out to be a testing ...
3 years, 7 months ago (2017-05-22 13:48:11 UTC) #2
floitsch
LGTM, but wait for Johnni.
3 years, 7 months ago (2017-05-22 13:52:37 UTC) #4
Johnni Winther
lgtm
3 years, 7 months ago (2017-05-23 08:05:18 UTC) #5
eernst
3 years, 7 months ago (2017-05-24 07:37:00 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
8aef60a78f2043a51c0d36b3b809f30e10ea3ed2 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698