third_party/WebKit/Source/core/style/ComputedStyle.cpp - Issue 2899663003: Make TextEmphasisFill an enum class.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/style/ComputedStyle.cpp

Issue 2899663003: Make TextEmphasisFill an enum class. (Closed)

Patch Set: Rebase Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/style/ComputedStyle.h ('k') | third_party/WebKit/Source/core/style/ComputedStyleConstants.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/style/ComputedStyle.cpp

diff --git a/third_party/WebKit/Source/core/style/ComputedStyle.cpp b/third_party/WebKit/Source/core/style/ComputedStyle.cpp

index 9a4c5c3894c442469d0000f6d5287b2d13cf790e..f06e55434e79900a135c66a5c6ea34f4e72694be 100644

--- a/third_party/WebKit/Source/core/style/ComputedStyle.cpp

+++ b/third_party/WebKit/Source/core/style/ComputedStyle.cpp

@@ -1589,7 +1589,7 @@ const AtomicString& ComputedStyle::TextEmphasisMarkString() const {

(&kBulletCharacter, 1));

DEFINE_STATIC_LOCAL(AtomicString, open_dot_string,

(&kWhiteBulletCharacter, 1));

- return GetTextEmphasisFill() == kTextEmphasisFillFilled

+ return GetTextEmphasisFill() == TextEmphasisFill::kFilled

? filled_dot_string

: open_dot_string;

}

@@ -1598,7 +1598,7 @@ const AtomicString& ComputedStyle::TextEmphasisMarkString() const {

(&kBlackCircleCharacter, 1));

DEFINE_STATIC_LOCAL(AtomicString, open_circle_string,

(&kWhiteCircleCharacter, 1));

- return GetTextEmphasisFill() == kTextEmphasisFillFilled

+ return GetTextEmphasisFill() == TextEmphasisFill::kFilled

? filled_circle_string

: open_circle_string;

}

@@ -1607,7 +1607,7 @@ const AtomicString& ComputedStyle::TextEmphasisMarkString() const {

(&kFisheyeCharacter, 1));

DEFINE_STATIC_LOCAL(AtomicString, open_double_circle_string,

(&kBullseyeCharacter, 1));

- return GetTextEmphasisFill() == kTextEmphasisFillFilled

+ return GetTextEmphasisFill() == TextEmphasisFill::kFilled

? filled_double_circle_string

: open_double_circle_string;

}

@@ -1616,7 +1616,7 @@ const AtomicString& ComputedStyle::TextEmphasisMarkString() const {

(&kBlackUpPointingTriangleCharacter, 1));

DEFINE_STATIC_LOCAL(AtomicString, open_triangle_string,

(&kWhiteUpPointingTriangleCharacter, 1));

- return GetTextEmphasisFill() == kTextEmphasisFillFilled

+ return GetTextEmphasisFill() == TextEmphasisFill::kFilled

? filled_triangle_string

: open_triangle_string;

}

@@ -1625,7 +1625,7 @@ const AtomicString& ComputedStyle::TextEmphasisMarkString() const {

(&kSesameDotCharacter, 1));

DEFINE_STATIC_LOCAL(AtomicString, open_sesame_string,

(&kWhiteSesameDotCharacter, 1));

- return GetTextEmphasisFill() == kTextEmphasisFillFilled

+ return GetTextEmphasisFill() == TextEmphasisFill::kFilled

? filled_sesame_string

: open_sesame_string;

}