Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(462)

Side by Side Diff: third_party/WebKit/Source/core/css/CSSPrimitiveValueMappings.h

Issue 2899663003: Make TextEmphasisFill an enum class. (Closed)
Patch Set: Rebase Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | third_party/WebKit/Source/core/css/ComputedStyleExtraFields.json5 » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2007 Alexey Proskuryakov <ap@nypop.com>. 2 * Copyright (C) 2007 Alexey Proskuryakov <ap@nypop.com>.
3 * Copyright (C) 2008, 2009, 2010, 2011 Apple Inc. All rights reserved. 3 * Copyright (C) 2008, 2009, 2010, 2011 Apple Inc. All rights reserved.
4 * Copyright (C) 2009 Torch Mobile Inc. All rights reserved. 4 * Copyright (C) 2009 Torch Mobile Inc. All rights reserved.
5 * (http://www.torchmobile.com/) 5 * (http://www.torchmobile.com/)
6 * Copyright (C) 2009 Jeff Schiller <codedread@gmail.com> 6 * Copyright (C) 2009 Jeff Schiller <codedread@gmail.com>
7 * Copyright (C) Research In Motion Limited 2010. All rights reserved. 7 * Copyright (C) Research In Motion Limited 2010. All rights reserved.
8 * 8 *
9 * Redistribution and use in source and binary forms, with or without 9 * Redistribution and use in source and binary forms, with or without
10 * modification, are permitted provided that the following conditions 10 * modification, are permitted provided that the following conditions
(...skipping 1646 matching lines...) Expand 10 before | Expand all | Expand 10 after
1657 } 1657 }
1658 1658
1659 NOTREACHED(); 1659 NOTREACHED();
1660 return kTextOverflowClip; 1660 return kTextOverflowClip;
1661 } 1661 }
1662 1662
1663 template <> 1663 template <>
1664 inline CSSIdentifierValue::CSSIdentifierValue(TextEmphasisFill fill) 1664 inline CSSIdentifierValue::CSSIdentifierValue(TextEmphasisFill fill)
1665 : CSSValue(kIdentifierClass) { 1665 : CSSValue(kIdentifierClass) {
1666 switch (fill) { 1666 switch (fill) {
1667 case kTextEmphasisFillFilled: 1667 case TextEmphasisFill::kFilled:
1668 value_id_ = CSSValueFilled; 1668 value_id_ = CSSValueFilled;
1669 break; 1669 break;
1670 case kTextEmphasisFillOpen: 1670 case TextEmphasisFill::kOpen:
1671 value_id_ = CSSValueOpen; 1671 value_id_ = CSSValueOpen;
1672 break; 1672 break;
1673 } 1673 }
1674 } 1674 }
1675 1675
1676 template <> 1676 template <>
1677 inline TextEmphasisFill CSSIdentifierValue::ConvertTo() const { 1677 inline TextEmphasisFill CSSIdentifierValue::ConvertTo() const {
1678 switch (value_id_) { 1678 switch (value_id_) {
1679 case CSSValueFilled: 1679 case CSSValueFilled:
1680 return kTextEmphasisFillFilled; 1680 return TextEmphasisFill::kFilled;
1681 case CSSValueOpen: 1681 case CSSValueOpen:
1682 return kTextEmphasisFillOpen; 1682 return TextEmphasisFill::kOpen;
1683 default: 1683 default:
1684 break; 1684 break;
1685 } 1685 }
1686 1686
1687 NOTREACHED(); 1687 NOTREACHED();
1688 return kTextEmphasisFillFilled; 1688 return TextEmphasisFill::kFilled;
1689 } 1689 }
1690 1690
1691 template <> 1691 template <>
1692 inline CSSIdentifierValue::CSSIdentifierValue(TextEmphasisMark mark) 1692 inline CSSIdentifierValue::CSSIdentifierValue(TextEmphasisMark mark)
1693 : CSSValue(kIdentifierClass) { 1693 : CSSValue(kIdentifierClass) {
1694 switch (mark) { 1694 switch (mark) {
1695 case kTextEmphasisMarkDot: 1695 case kTextEmphasisMarkDot:
1696 value_id_ = CSSValueDot; 1696 value_id_ = CSSValueDot;
1697 break; 1697 break;
1698 case kTextEmphasisMarkCircle: 1698 case kTextEmphasisMarkCircle:
(...skipping 1621 matching lines...) Expand 10 before | Expand all | Expand 10 after
3320 default: 3320 default:
3321 break; 3321 break;
3322 } 3322 }
3323 NOTREACHED(); 3323 NOTREACHED();
3324 return kContainsNone; 3324 return kContainsNone;
3325 } 3325 }
3326 3326
3327 } // namespace blink 3327 } // namespace blink
3328 3328
3329 #endif 3329 #endif
OLDNEW
« no previous file with comments | « no previous file | third_party/WebKit/Source/core/css/ComputedStyleExtraFields.json5 » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698