Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3457)

Unified Diff: chrome/browser/ui/views/payments/payment_sheet_view_controller.cc

Issue 2899653002: Remove uses of FontList::Derive*(..) in views payments dialogs. (Closed)
Patch Set: self review Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/views/payments/payment_sheet_view_controller.cc
diff --git a/chrome/browser/ui/views/payments/payment_sheet_view_controller.cc b/chrome/browser/ui/views/payments/payment_sheet_view_controller.cc
index 3e83ac61f77a144144b0a616c1e20bb8e71c7730..b0e1d669a52a7694088d5dfa5e55ff35765a4521 100644
--- a/chrome/browser/ui/views/payments/payment_sheet_view_controller.cc
+++ b/chrome/browser/ui/views/payments/payment_sheet_view_controller.cc
@@ -139,14 +139,11 @@ int ComputeWidestNameColumnViewWidth() {
int widest_column_width = 0;
- views::Label label(base::ASCIIToUTF16(""));
- label.SetFontList(
- label.font_list().DeriveWithWeight(gfx::Font::Weight::MEDIUM));
+ std::unique_ptr<views::Label> label = CreateMediumLabel(base::string16());
for (int name_id : section_names) {
- label.SetText(l10n_util::GetStringUTF16(name_id));
- widest_column_width = std::max(
- label.GetPreferredSize().width(),
- widest_column_width);
+ label->SetText(l10n_util::GetStringUTF16(name_id));
+ widest_column_width =
+ std::max(label->GetPreferredSize().width(), widest_column_width);
}
return widest_column_width;
@@ -198,10 +195,7 @@ std::unique_ptr<views::Button> CreatePaymentSheetRow(
0, views::GridLayout::USE_PREF, 0, 0);
layout->StartRow(0, 0);
- views::Label* name_label = new views::Label(section_name);
- name_label->SetFontList(
- name_label->font_list().DeriveWithWeight(gfx::Font::Weight::MEDIUM));
- layout->AddView(name_label);
+ layout->AddView(CreateMediumLabel(section_name).release());
if (content_view) {
content_view->set_can_process_events_within_subtree(false);

Powered by Google App Engine
This is Rietveld 408576698