Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(113)

Issue 289963002: Use new WebServiceWorkerError::ErrorType names. (Closed)

Created:
6 years, 7 months ago by dominicc (has gone to gerrit)
Modified:
6 years, 7 months ago
Reviewers:
kinuko
CC:
chromium-reviews, michaeln, jsbell+serviceworker_chromium.org, tzik, serviceworker-reviews, jam, nhiroki, darin-cc_chromium.org, horo+watch_chromium.org, kinuko+watch, alecflett+watch_chromium.org
Visibility:
Public.

Description

Use new WebServiceWorkerError::ErrorType names. BUG=373594 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=270984

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -7 lines) Patch
M content/browser/service_worker/service_worker_dispatcher_host.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M content/browser/service_worker/service_worker_registration_status.cc View 2 chunks +4 lines, -4 lines 0 comments Download

Messages

Total messages: 12 (0 generated)
dominicc (has gone to gerrit)
PTAL This is some clean-up tkent indicated when I added the NotFoundError. This has to ...
6 years, 7 months ago (2014-05-15 07:13:54 UTC) #1
kinuko
lgtm
6 years, 7 months ago (2014-05-15 14:19:21 UTC) #2
dominicc (has gone to gerrit)
The CQ bit was checked by dominicc@chromium.org
6 years, 7 months ago (2014-05-16 01:23:58 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dominicc@chromium.org/289963002/1
6 years, 7 months ago (2014-05-16 01:26:45 UTC) #4
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). Please consider checking whether the failures are ...
6 years, 7 months ago (2014-05-16 05:09:44 UTC) #5
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 7 months ago (2014-05-16 05:19:25 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: android_dbg on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/android_dbg/builds/184736)
6 years, 7 months ago (2014-05-16 05:19:25 UTC) #7
dominicc (has gone to gerrit)
The CQ bit was checked by dominicc@chromium.org
6 years, 7 months ago (2014-05-16 07:14:18 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dominicc@chromium.org/289963002/1
6 years, 7 months ago (2014-05-16 07:14:52 UTC) #9
dominicc (has gone to gerrit)
On 2014/05/16 05:19:25, I haz the power (commit-bot) wrote: > Try jobs failed on following ...
6 years, 7 months ago (2014-05-16 07:14:58 UTC) #10
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). Please consider checking whether the failures are ...
6 years, 7 months ago (2014-05-16 10:13:07 UTC) #11
commit-bot: I haz the power
6 years, 7 months ago (2014-05-16 11:14:38 UTC) #12
Message was sent while issue was closed.
Change committed as 270984

Powered by Google App Engine
This is Rietveld 408576698