third_party/WebKit/Source/core/inspector/InspectorTaskRunner.cpp - Issue 2899573002: Clean up remaining uses of ASSERT in core

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/inspector/InspectorTaskRunner.cpp

Issue 2899573002: Clean up remaining uses of ASSERT in core (Closed)

Patch Set: Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/inspector/InspectorTaskRunner.cpp

diff --git a/third_party/WebKit/Source/core/inspector/InspectorTaskRunner.cpp b/third_party/WebKit/Source/core/inspector/InspectorTaskRunner.cpp

index 375c86a6124b95f0f26256b9a05dd84a13f0996c..928e63440754da59b251e61cb501f741662ec311 100644

--- a/third_party/WebKit/Source/core/inspector/InspectorTaskRunner.cpp

+++ b/third_party/WebKit/Source/core/inspector/InspectorTaskRunner.cpp

@@ -41,7 +41,7 @@ std::unique_ptr<InspectorTaskRunner::Task> InspectorTaskRunner::TakeNextTask(

double absolute_time = wait_mode == kWaitForTask ? infinite_time : 0.0;

while (!killed_ && !timed_out && queue_.IsEmpty())

timed_out = !condition_.TimedWait(mutex_, absolute_time);

- ASSERT(!timed_out || absolute_time != infinite_time);

+ DCHECK(!timed_out || absolute_time != infinite_time);

if (killed_ || timed_out)

return nullptr;