Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3469)

Unified Diff: chrome/browser/resources/settings/controls/settings_toggle_button.js

Issue 2899533002: [MD settings] move <dialog> out of content (Closed)
Patch Set: focusWithoutInk Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/resources/settings/controls/settings_toggle_button.js
diff --git a/chrome/browser/resources/settings/controls/settings_toggle_button.js b/chrome/browser/resources/settings/controls/settings_toggle_button.js
index 1352bccfeadf21ee4242a8d4dfe60e9c1e330d12..6b636b5d4c291933d524a408374896d26d5a8ca8 100644
--- a/chrome/browser/resources/settings/controls/settings_toggle_button.js
+++ b/chrome/browser/resources/settings/controls/settings_toggle_button.js
@@ -9,6 +9,8 @@
Polymer({
is: 'settings-toggle-button',
+ behaviors: [SettingsBooleanControlBehavior],
dschuyler 2017/05/23 23:29:25 Just moved, not changed.
+
properties: {
elideLabel: {
type: Boolean,
@@ -16,7 +18,10 @@ Polymer({
},
},
- behaviors: [SettingsBooleanControlBehavior],
+ /** @private */
hcarmona 2017/05/24 18:05:36 Should this be @override instead?
dschuyler 2017/05/24 20:39:07 Done.
+ focus: function() {
+ this.$.control.focus();
dschuyler 2017/05/23 23:29:25 Pass along the focus to avoid doing this elsewhere
+ },
/** @private */
onLabelWrapperTap_: function() {

Powered by Google App Engine
This is Rietveld 408576698