Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(291)

Issue 289953004: Add GPU command buffer sevice and protobuf to GN build (Closed)

Created:
6 years, 7 months ago by brettw
Modified:
6 years, 7 months ago
Reviewers:
piman
CC:
chromium-reviews
Visibility:
Public.

Description

Add GPU command buffer sevice and protobuf to GN build Adds a protobuf target and a template for defining protos. This handles doing host builds of protoc when cross-compiling. The command buffer sevice wants more optimization on Android, so this patch generalizes the solution. Normally Android, like Windows, optimizes for size. This now adds support on Android for speed optimization just like Windows does. Mac & Linux always optimize for speed. Removes the declare_args call around the gcc_version. This was parameterized to be different if is_android was set, which isn't valid because build parameters can't vary across toolchains. Since this value is derived from the environment, I just removed the declare_args call. BUG= R=piman@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=271941

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : #

Total comments: 2

Patch Set 5 : gyp fixed #

Patch Set 6 : #

Patch Set 7 : #

Patch Set 8 : #

Patch Set 9 : git branhc #

Patch Set 10 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+553 lines, -15 lines) Patch
M BUILD.gn View 1 2 3 4 5 6 7 8 9 3 chunks +5 lines, -0 lines 0 comments Download
M build/config/compiler/BUILD.gn View 1 2 3 4 5 3 chunks +12 lines, -6 lines 0 comments Download
M build/config/gcc/gcc_version.gni View 1 2 3 4 5 1 chunk +4 lines, -6 lines 0 comments Download
A gpu/command_buffer/service/BUILD.gn View 1 2 3 4 1 chunk +156 lines, -0 lines 0 comments Download
A third_party/protobuf/BUILD.gn View 1 2 3 1 chunk +241 lines, -0 lines 0 comments Download
A third_party/protobuf/proto_library.gni View 1 2 3 1 chunk +125 lines, -0 lines 0 comments Download
M ui/gfx/BUILD.gn View 1 2 3 4 5 6 1 chunk +4 lines, -3 lines 0 comments Download
M ui/gl/BUILD.gn View 1 2 3 4 5 2 chunks +6 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
brettw
6 years, 7 months ago (2014-05-19 23:58:27 UTC) #1
piman
https://codereview.chromium.org/289953004/diff/40001/gpu/gpu.gyp File gpu/gpu.gyp (right): https://codereview.chromium.org/289953004/diff/40001/gpu/gpu.gyp#newcode207 gpu/gpu.gyp:207: 'command_buffer/client/vertex_array_objectmanager_unittest.cc', typo?
6 years, 7 months ago (2014-05-20 01:26:16 UTC) #2
brettw
New snap up https://codereview.chromium.org/289953004/diff/40001/gpu/gpu.gyp File gpu/gpu.gyp (right): https://codereview.chromium.org/289953004/diff/40001/gpu/gpu.gyp#newcode207 gpu/gpu.gyp:207: 'command_buffer/client/vertex_array_objectmanager_unittest.cc', Oh yeah, I fixed that ...
6 years, 7 months ago (2014-05-20 02:35:35 UTC) #3
piman
lgtm
6 years, 7 months ago (2014-05-20 02:48:05 UTC) #4
brettw
6 years, 7 months ago (2014-05-21 19:42:36 UTC) #5
Message was sent while issue was closed.
Committed patchset #10 manually as r271941.

Powered by Google App Engine
This is Rietveld 408576698