Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1267)

Unified Diff: net/nqe/network_quality_estimator_test_util.cc

Issue 2899453002: Pass parsed network quality estimator params when constructing NQE (Closed)
Patch Set: Fix Android compile error Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: net/nqe/network_quality_estimator_test_util.cc
diff --git a/net/nqe/network_quality_estimator_test_util.cc b/net/nqe/network_quality_estimator_test_util.cc
index c6005bb1052aeca1f0530aca939b4475f96db99f..742c55fdeafd18ed7e5925e3f72d1519f9946c2b 100644
--- a/net/nqe/network_quality_estimator_test_util.cc
+++ b/net/nqe/network_quality_estimator_test_util.cc
@@ -11,6 +11,7 @@
#include "net/log/net_log_with_source.h"
#include "net/log/test_net_log.h"
#include "net/log/test_net_log_entry.h"
+#include "net/nqe/network_quality_estimator_params.h"
#include "net/test/embedded_test_server/http_response.h"
#include "net/traffic_annotation/network_traffic_annotation_test_helper.h"
#include "net/url_request/url_request.h"
@@ -51,12 +52,14 @@ TestNetworkQualityEstimator::TestNetworkQualityEstimator(
bool allow_smaller_responses_for_tests,
bool add_default_platform_observations,
std::unique_ptr<BoundTestNetLog> net_log)
- : NetworkQualityEstimator(std::move(external_estimate_provider),
- variation_params,
- allow_local_host_requests_for_tests,
- allow_smaller_responses_for_tests,
- add_default_platform_observations,
- net_log->bound()),
+ : NetworkQualityEstimator(
+ std::move(external_estimate_provider),
+ base::MakeUnique<nqe::internal::NetworkQualityEstimatorParams>(
+ variation_params),
+ allow_local_host_requests_for_tests,
+ allow_smaller_responses_for_tests,
+ add_default_platform_observations,
+ net_log->bound()),
current_network_type_(NetworkChangeNotifier::CONNECTION_UNKNOWN),
accuracy_recording_intervals_set_(false),
rand_double_(0.0),

Powered by Google App Engine
This is Rietveld 408576698