Support reflectClass on parameterized classes

Support reflectClass on parameterized classes

Internal pageloader usage hits this.

R=rnystrom@google.com

Committed: https://github.com/dart-lang/sdk/commit/75afaf5a24d970a111e468d614a4f6d3d9a23d07

[vsm, 2017-05-25 20:09:06]

Description was changed from

==========
Support reflectClass on parameterized classes
==========

to

==========
Support reflectClass on parameterized classes

Internal pageloader usage hits this.
==========

[vsm, 2017-05-25 20:09:06]

vsm@google.com changed reviewers:
+ rnystrom@google.com

[Bob Nystrom, 2017-05-25 20:16:05]

lgtm

https://codereview.chromium.org/2899343004/diff/1/pkg/dev_compiler/test/brows...
File pkg/dev_compiler/test/browser/language_tests.js (left):

https://codereview.chromium.org/2899343004/diff/1/pkg/dev_compiler/test/brows...
pkg/dev_compiler/test/browser/language_tests.js:651: 'raw_type_test_none_multi':
fail,
Always nice seeing more tests passing!

https://codereview.chromium.org/2899343004/diff/1/pkg/dev_compiler/tool/input...
File pkg/dev_compiler/tool/input_sdk/private/js_mirrors.dart (right):

https://codereview.chromium.org/2899343004/diff/1/pkg/dev_compiler/tool/input...
pkg/dev_compiler/tool/input_sdk/private/js_mirrors.dart:446: _raw = null,
There's some duplication between these. Maybe a single constructor like:

JsClassMirror._(Type cls, {bool instantiated = true})
    : _cls = cls,
      _raw = instantiated ? _getGenericClass(_unwrap(cls)) : null,
      simpleName = new Symbol(JS('String', '#.name', _unwrap(cls))) {
  _initialize();
}

[vsm, 2017-05-25 20:26:52]

https://codereview.chromium.org/2899343004/diff/1/pkg/dev_compiler/tool/input...
File pkg/dev_compiler/tool/input_sdk/private/js_mirrors.dart (right):

https://codereview.chromium.org/2899343004/diff/1/pkg/dev_compiler/tool/input...
pkg/dev_compiler/tool/input_sdk/private/js_mirrors.dart:446: _raw = null,
On 2017/05/25 20:16:05, Bob Nystrom wrote:
> There's some duplication between these. Maybe a single constructor like:
> 
> JsClassMirror._(Type cls, {bool instantiated = true})
>     : _cls = cls,
>       _raw = instantiated ? _getGenericClass(_unwrap(cls)) : null,
>       simpleName = new Symbol(JS('String', '#.name', _unwrap(cls))) {
>   _initialize();
> }

That is cleaner.  :-)  

Done and re-inlined initialize as well.

[vsm, 2017-05-25 20:27:45]

Description was changed from

==========
Support reflectClass on parameterized classes

Internal pageloader usage hits this.
==========

to

==========
Support reflectClass on parameterized classes

Internal pageloader usage hits this.

R=rnystrom@google.com

Committed:
https://github.com/dart-lang/sdk/commit/75afaf5a24d970a111e468d614a4f6d3d9a23d07
==========

[vsm, 2017-05-25 20:27:46]

Committed patchset #2 (id:10001) manually as
75afaf5a24d970a111e468d614a4f6d3d9a23d07 (presubmit successful).