Heap::kNew-space allocations discovered by experimental code called transitively from parser

runtime/vm/isolate_reload.cc

 // Copyright (c) 2016, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #include "vm/isolate_reload.h"
 
 #include "vm/become.h"
 #include "vm/bit_vector.h"
 #include "vm/runtime_entry.h"
 #include "vm/compiler.h"
@@ skipping 554 matching lines @@
     ReportOnJSON(js_);
     TIR_Print("---- SKIPPING RELOAD (No libraries were modified)\n");
     return;
   }
 
   TIR_Print("---- STARTING RELOAD\n");
 
   // Preallocate storage for maps.
   old_classes_set_storage_ =
       HashTables::New<UnorderedHashSet<ClassMapTraits> >(4);
-  class_map_storage_ = HashTables::New<UnorderedHashMap<ClassMapTraits> >(4);
+  class_map_storage_ =
+      HashTables::New<UnorderedHashMap<ClassMapTraits> >(4, Heap::kOld);
   old_libraries_set_storage_ =
       HashTables::New<UnorderedHashSet<LibraryMapTraits> >(4);
   library_map_storage_ =
       HashTables::New<UnorderedHashMap<LibraryMapTraits> >(4);
-  become_map_storage_ = HashTables::New<UnorderedHashMap<BecomeMapTraits> >(4);
+  become_map_storage_ =
+      HashTables::New<UnorderedHashMap<BecomeMapTraits> >(4, Heap::kOld);
   // Keep a separate array for enum mappings to avoid having to invoke
   // hashCode on the instances.
   become_enum_mappings_ = GrowableObjectArray::New(Heap::kOld);
 
   // Disable the background compiler while we are performing the reload.
   BackgroundCompiler::Disable();
 
   // Ensure all functions on the stack have unoptimized code.
   EnsuredUnoptimizedCodeForStack();
   // Deoptimize all code that had optimizing decisions that are dependent on
@@ skipping 1162 matching lines @@
 // Attempt to find the pair to |replacement_or_new| with the knowledge that
 // the base url prefix has moved.
 RawLibrary* IsolateReloadContext::OldLibraryOrNullBaseMoved(
     const Library& replacement_or_new) {
   const String& url_prefix = String::Handle(root_url_prefix_);
   const String& old_url_prefix = String::Handle(old_root_url_prefix_);
   const intptr_t prefix_length = url_prefix.Length();
   const intptr_t old_prefix_length = old_url_prefix.Length();
   const String& new_url = String::Handle(replacement_or_new.url());
   const String& suffix =
-      String::Handle(String::SubString(new_url, prefix_length));
+      String::Handle(String::SubString(new_url, prefix_length, Heap::kOld));
   if (!new_url.StartsWith(url_prefix)) {
     return Library::null();
   }
   Library& old = Library::Handle();
   String& old_url = String::Handle();
   String& old_suffix = String::Handle();
   GrowableObjectArray& saved_libs =
       GrowableObjectArray::Handle(saved_libraries());
   ASSERT(!saved_libs.IsNull());
   for (intptr_t i = 0; i < saved_libs.Length(); i++) {
     old = Library::RawCast(saved_libs.At(i));
     old_url = old.url();
     if (!old_url.StartsWith(old_url_prefix)) {
       continue;
     }
-    old_suffix ^= String::SubString(old_url, old_prefix_length);
+    old_suffix ^= String::SubString(old_url, old_prefix_length, Heap::kOld);
     if (old_suffix.IsNull()) {
       continue;
     }
     if (old_suffix.Equals(suffix)) {
       TIR_Print("`%s` is moving to `%s`\n", old_url.ToCString(),
                 new_url.ToCString());
       return old.raw();
     }
   }
   return Library::null();
@@ skipping 108 matching lines @@
         ASSERT(!super_cls.IsNull());
         super_cls.AddDirectSubclass(cls);
       }
     }
   }
 }
 
 #endif  // !PRODUCT
 
 }  // namespace dart