Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(10)

Unified Diff: chrome/browser/profiles/profile_io_data.cc

Issue 2899313006: Plumb NQP to context and to http_proxy_client_socket_pool (Closed)
Patch Set: ps Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/profiles/profile_io_data.cc
diff --git a/chrome/browser/profiles/profile_io_data.cc b/chrome/browser/profiles/profile_io_data.cc
index 644fd76b0ff6405def02008a4b389b14819acde0..8e176cf92790a4ac5081f026b0c8ae3aa7ad3452 100644
--- a/chrome/browser/profiles/profile_io_data.cc
+++ b/chrome/browser/profiles/profile_io_data.cc
@@ -1312,11 +1312,13 @@ ProfileIOData::CreateHttpNetworkSession(
net::HttpNetworkSession::Context session_context;
net::URLRequestContextBuilder::SetHttpNetworkSessionComponents(
context, &session_context);
- if (!IsOffTheRecord() && io_thread->globals()->network_quality_estimator) {
- session_context.socket_performance_watcher_factory =
- io_thread->globals()
- ->network_quality_estimator->GetSocketPerformanceWatcherFactory();
- }
+ DCHECK(io_thread->globals()->network_quality_estimator);
+ session_context.socket_performance_watcher_factory =
+ io_thread->globals()
+ ->network_quality_estimator->GetSocketPerformanceWatcherFactory();
mmenke 2017/06/05 20:04:25 Is hooking this up in incognito mode a critical pa
tbansal1 2017/06/07 18:13:44 Done.
+ session_context.network_quality_estimator =
+ io_thread->globals()->network_quality_estimator.get();
mmenke 2017/06/05 20:04:25 Not needed, since it's plugged into SetHttpNetwork
tbansal1 2017/06/07 18:13:44 Done.
+
if (data_reduction_proxy_io_data_.get()) {
session_context.proxy_delegate =
data_reduction_proxy_io_data_->proxy_delegate();

Powered by Google App Engine
This is Rietveld 408576698