Plumb NQP to context and to http_proxy_client_socket_pool

net/http/http_network_session.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef NET_HTTP_HTTP_NETWORK_SESSION_H_
 #define NET_HTTP_HTTP_NETWORK_SESSION_H_
 
 #include <stddef.h>
 #include <stdint.h>
 
@@ skipping 37 matching lines @@
 class ClientSocketFactory;
 class ClientSocketPoolManager;
 class CTVerifier;
 class HostResolver;
 class HttpAuthHandlerFactory;
 class HttpNetworkSessionPeer;
 class HttpProxyClientSocketPool;
 class HttpResponseBodyDrainer;
 class HttpServerProperties;
 class NetLog;
+class NetworkQualityEstimator;
 class NetworkThrottleManager;
 class ProxyDelegate;
 class ProxyService;
 class QuicClock;
 class QuicCryptoClientStreamFactory;
 class SocketPerformanceWatcherFactory;
 class SOCKSClientSocketPool;
 class SSLClientSocketPool;
 class SSLConfigService;
 class TransportClientSocketPool;
@@ skipping 113 matching lines @@
     ChannelIDService* channel_id_service;
     TransportSecurityState* transport_security_state;
     CTVerifier* cert_transparency_verifier;
     CTPolicyEnforcer* ct_policy_enforcer;
     ProxyService* proxy_service;
     SSLConfigService* ssl_config_service;
     HttpAuthHandlerFactory* http_auth_handler_factory;
     HttpServerProperties* http_server_properties;
     NetLog* net_log;
     SocketPerformanceWatcherFactory* socket_performance_watcher_factory;
+    NetworkQualityEstimator* network_quality_estimator;

[mmenke, 2017/06/05 20:04:26]

Having the bottom layer of the network stack depend on an API that depends on
the top of the network stack (URLRequest) seems like bad API layering to me.

I'm open to other way to avoid this, but one option is to make NQE a virtual
interface, with only observer / get-network-info-type methods, and then make
NQEImpl (Which could completely reasonably be part of URLRequestContext) depend
on URLRequests.

Another option is to make a separate class that NQE either subclasses or that
depends on the NQE, that provides the socket pools with the API they need.

[tbansal1, 2017/06/07 18:13:44]

Done.

 
     // Source of time for QUIC connections.
     QuicClock* quic_clock;
     // Source of entropy for QUIC connections.
     QuicRandom* quic_random;
     // Optional factory to use for creating QuicCryptoClientStreams.
     QuicCryptoClientStreamFactory* quic_crypto_client_stream_factory;
 
     ProxyDelegate* proxy_delegate;
   };
@@ skipping 135 matching lines @@
   Context context_;
 
   std::unique_ptr<base::MemoryPressureListener> memory_pressure_listener_;
 
   THREAD_CHECKER(thread_checker_);
 };
 
 }  // namespace net
 
 #endif  // NET_HTTP_HTTP_NETWORK_SESSION_H_