Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5)

Issue 289923004: Rename layout test filenames with "cat" and "hat" combinators (Closed)

Created:
6 years, 7 months ago by kochi
Modified:
6 years, 7 months ago
Reviewers:
hayato, tasak
CC:
blink-reviews, hayato
Visibility:
Public.

Description

Rename layout test filenames with "cat" and "hat" combinators Rename test filenames with obsolete "cat" (^) and "hat" (^^) combinators to ones that conforming to the current spec (e.g. /deep/ (deep combinator), ::shadow (shadow pseudo element), :host (host pseudo class). Changes are filenames only and no functional change in actual tests. BUG=none TEST=Run affected layout tests. Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=174074

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+-10 lines, -1144 lines) Patch
D LayoutTests/fast/dom/shadow/content-pseudo-element-with-cat.html View 1 chunk +0 lines, -124 lines 0 comments Download
D LayoutTests/fast/dom/shadow/content-pseudo-element-with-cat-expected.txt View 1 chunk +0 lines, -14 lines 0 comments Download
A + LayoutTests/fast/dom/shadow/content-pseudo-element-with-deep-combinator-and-host-pseudo-class.html View 0 chunks +-1 lines, --1 lines 0 comments Download
A + LayoutTests/fast/dom/shadow/content-pseudo-element-with-deep-combinator-and-host-pseudo-class-expected.txt View 0 chunks +-1 lines, --1 lines 0 comments Download
D LayoutTests/fast/dom/shadow/content-pseudo-element-with-hat.html View 1 chunk +0 lines, -100 lines 0 comments Download
D LayoutTests/fast/dom/shadow/content-pseudo-element-with-hat-expected.txt View 1 chunk +0 lines, -13 lines 0 comments Download
A + LayoutTests/fast/dom/shadow/content-pseudo-element-with-shadow-pseudo-element-and-host-pseudo-class.html View 0 chunks +-1 lines, --1 lines 0 comments Download
A + LayoutTests/fast/dom/shadow/content-pseudo-element-with-shadow-pseudo-element-and-host-pseudo-class-expected.txt View 0 chunks +-1 lines, --1 lines 0 comments Download
D LayoutTests/fast/dom/shadow/dynamically-added-cat-hat-rules.html View 1 chunk +0 lines, -53 lines 0 comments Download
D LayoutTests/fast/dom/shadow/dynamically-added-cat-hat-rules-expected.txt View 1 chunk +0 lines, -10 lines 0 comments Download
A + LayoutTests/fast/dom/shadow/dynamically-added-deep-combinator-and-shadow-pseudo-element.html View 0 chunks +-1 lines, --1 lines 0 comments Download
A + LayoutTests/fast/dom/shadow/dynamically-added-deep-combinator-and-shadow-pseudo-element-expected.txt View 0 chunks +-1 lines, --1 lines 0 comments Download
D LayoutTests/fast/dom/shadow/style-with-cat.html View 1 chunk +0 lines, -425 lines 0 comments Download
D LayoutTests/fast/dom/shadow/style-with-cat-expected.txt View 1 chunk +0 lines, -34 lines 0 comments Download
A + LayoutTests/fast/dom/shadow/style-with-deep-combinator.html View 0 chunks +-1 lines, --1 lines 0 comments Download
A + LayoutTests/fast/dom/shadow/style-with-deep-combinator-expected.txt View 0 chunks +-1 lines, --1 lines 0 comments Download
D LayoutTests/fast/dom/shadow/style-with-hat.html View 1 chunk +0 lines, -348 lines 0 comments Download
D LayoutTests/fast/dom/shadow/style-with-hat-expected.txt View 1 chunk +0 lines, -33 lines 0 comments Download
A + LayoutTests/fast/dom/shadow/style-with-shadow-pseudo-element.html View 0 chunks +-1 lines, --1 lines 0 comments Download
A + LayoutTests/fast/dom/shadow/style-with-shadow-pseudo-element-expected.txt View 0 chunks +-1 lines, --1 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
kochi
Hi Takashi, This renames shadow dom layout tests with "cat" or "hat" in their filenames. ...
6 years, 7 months ago (2014-05-15 05:04:25 UTC) #1
kochi
+cc hayato
6 years, 7 months ago (2014-05-15 06:46:35 UTC) #2
hayato
lgtm
6 years, 7 months ago (2014-05-15 07:54:33 UTC) #3
kochi
The CQ bit was checked by kochi@chromium.org
6 years, 7 months ago (2014-05-15 08:08:56 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kochi@chromium.org/289923004/1
6 years, 7 months ago (2014-05-15 08:09:15 UTC) #5
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). Please consider checking whether the failures are ...
6 years, 7 months ago (2014-05-15 09:37:03 UTC) #6
commit-bot: I haz the power
6 years, 7 months ago (2014-05-15 10:57:25 UTC) #7
Message was sent while issue was closed.
Change committed as 174074

Powered by Google App Engine
This is Rietveld 408576698