Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1784)

Unified Diff: extensions/browser/api/media_perception_private/media_perception_api_manager_unittest.cc

Issue 2899223003: Revert of MediaPerceptionPrivate API impl and testing. (Closed)
Patch Set: Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: extensions/browser/api/media_perception_private/media_perception_api_manager_unittest.cc
diff --git a/extensions/browser/api/media_perception_private/media_perception_api_manager_unittest.cc b/extensions/browser/api/media_perception_private/media_perception_api_manager_unittest.cc
deleted file mode 100644
index 47180d3e3ea980ea82ce60dd4be98efb119cdadb..0000000000000000000000000000000000000000
--- a/extensions/browser/api/media_perception_private/media_perception_api_manager_unittest.cc
+++ /dev/null
@@ -1,208 +0,0 @@
-// Copyright 2017 The Chromium Authors. All rights reserved.
-// Use of this source code is governed by a BSD-style license that can be
-// found in the LICENSE file.
-
-#include "extensions/browser/api/media_perception_private/media_perception_api_manager.h"
-
-#include <queue>
-
-#include "base/bind.h"
-#include "base/memory/ptr_util.h"
-#include "base/run_loop.h"
-#include "chromeos/dbus/dbus_thread_manager.h"
-#include "chromeos/dbus/fake_media_analytics_client.h"
-#include "chromeos/dbus/fake_upstart_client.h"
-#include "chromeos/dbus/media_analytics_client.h"
-#include "chromeos/dbus/upstart_client.h"
-#include "content/public/test/test_browser_context.h"
-#include "content/public/test/test_browser_thread_bundle.h"
-#include "testing/gtest/include/gtest/gtest.h"
-
-namespace media_perception = extensions::api::media_perception_private;
-
-namespace chromeos {
-namespace {
-
-class TestUpstartClient : public FakeUpstartClient {
- public:
- TestUpstartClient() : enqueue_requests_(false) {}
-
- ~TestUpstartClient() override{};
-
- // Overrides behavior to queue start requests.
- void StartMediaAnalytics(const UpstartCallback& callback) override {
- pending_upstart_request_callbacks_.push(callback);
- if (!enqueue_requests_) {
- HandleNextUpstartRequest(true);
- return;
- }
- }
-
- // Triggers the next queue'd start request to succeed or fail.
- bool HandleNextUpstartRequest(bool should_succeed) {
- if (pending_upstart_request_callbacks_.empty())
- return false;
-
- UpstartCallback callback = pending_upstart_request_callbacks_.front();
- pending_upstart_request_callbacks_.pop();
-
- if (!should_succeed) {
- callback.Run(false);
- return true;
- }
-
- FakeUpstartClient::StartMediaAnalytics(callback);
- return true;
- }
-
- void set_enqueue_requests(bool enqueue_requests) {
- enqueue_requests_ = enqueue_requests;
- }
-
- private:
- std::queue<UpstartCallback> pending_upstart_request_callbacks_;
-
- bool enqueue_requests_;
-
- DISALLOW_COPY_AND_ASSIGN(TestUpstartClient);
-};
-
-} // namespace
-} // namespace chromeos
-
-namespace extensions {
-
-using CallbackStatus = MediaPerceptionAPIManager::CallbackStatus;
-
-namespace {
-
-void RecordStatusAndRunClosure(base::Closure quit_run_loop,
- CallbackStatus* status,
- CallbackStatus result_status,
- media_perception::State result_state) {
- *status = result_status;
- quit_run_loop.Run();
-}
-
-CallbackStatus SetStateAndWaitForResponse(
- MediaPerceptionAPIManager* manager,
- const media_perception::State& state) {
- base::RunLoop run_loop;
- CallbackStatus status;
- manager->SetState(state, base::Bind(&RecordStatusAndRunClosure,
- run_loop.QuitClosure(), &status));
- run_loop.Run();
- return status;
-}
-
-CallbackStatus GetStateAndWaitForResponse(MediaPerceptionAPIManager* manager) {
- base::RunLoop run_loop;
- CallbackStatus status;
- manager->GetState(
- base::Bind(&RecordStatusAndRunClosure, run_loop.QuitClosure(), &status));
- run_loop.Run();
- return status;
-}
-
-} // namespace
-
-class MediaPerceptionAPIManagerTest : public testing::Test {
- public:
- MediaPerceptionAPIManagerTest()
- : thread_bundle_(content::TestBrowserThreadBundle::DEFAULT) {}
-
- void SetUp() override {
- std::unique_ptr<chromeos::DBusThreadManagerSetter> dbus_setter =
- chromeos::DBusThreadManager::GetSetterForTesting();
- auto media_analytics_client =
- base::MakeUnique<chromeos::FakeMediaAnalyticsClient>();
- media_analytics_client_ = media_analytics_client.get();
- dbus_setter->SetMediaAnalyticsClient(std::move(media_analytics_client));
-
- auto upstart_client = base::MakeUnique<chromeos::TestUpstartClient>();
- upstart_client_ = upstart_client.get();
- dbus_setter->SetUpstartClient(std::move(upstart_client));
-
- manager_ = base::MakeUnique<MediaPerceptionAPIManager>(&browser_context_);
- }
-
- void TearDown() override {
- // Need to make sure that the MediaPerceptionAPIManager is destructed before
- // the DbusThreadManager.
- manager_.reset();
- chromeos::DBusThreadManager::Shutdown();
- }
-
- std::unique_ptr<MediaPerceptionAPIManager> manager_;
-
- // Ownership of both is passed on to chromeos::DbusThreadManager.
- chromeos::FakeMediaAnalyticsClient* media_analytics_client_;
- chromeos::TestUpstartClient* upstart_client_;
-
- private:
- content::TestBrowserContext browser_context_;
- content::TestBrowserThreadBundle thread_bundle_;
-
- DISALLOW_COPY_AND_ASSIGN(MediaPerceptionAPIManagerTest);
-};
-
-TEST_F(MediaPerceptionAPIManagerTest, UpstartFailure) {
- upstart_client_->set_enqueue_requests(true);
- media_perception::State state;
- state.status = media_perception::STATUS_RUNNING;
-
- base::RunLoop run_loop;
- CallbackStatus status;
- manager_->SetState(state, base::Bind(&RecordStatusAndRunClosure,
- run_loop.QuitClosure(), &status));
- EXPECT_TRUE(upstart_client_->HandleNextUpstartRequest(false));
- run_loop.Run();
- EXPECT_EQ(CallbackStatus::PROCESS_IDLE_ERROR, status);
-
- // Check that after a failed request, setState RUNNING will go through.
- upstart_client_->set_enqueue_requests(false);
- EXPECT_EQ(CallbackStatus::SUCCESS,
- SetStateAndWaitForResponse(manager_.get(), state));
-}
-
-TEST_F(MediaPerceptionAPIManagerTest, UpstartStall) {
- upstart_client_->set_enqueue_requests(true);
- media_perception::State state;
- state.status = media_perception::STATUS_RUNNING;
-
- base::RunLoop run_loop;
- CallbackStatus status;
- manager_->SetState(state, base::Bind(&RecordStatusAndRunClosure,
- run_loop.QuitClosure(), &status));
-
- EXPECT_EQ(CallbackStatus::PROCESS_LAUNCHING_ERROR,
- GetStateAndWaitForResponse(manager_.get()));
- EXPECT_EQ(CallbackStatus::PROCESS_LAUNCHING_ERROR,
- SetStateAndWaitForResponse(manager_.get(), state));
- EXPECT_TRUE(upstart_client_->HandleNextUpstartRequest(true));
- run_loop.Run();
- EXPECT_EQ(CallbackStatus::SUCCESS, status);
-
- // Verify that after the slow start, things works as normal.
- upstart_client_->set_enqueue_requests(false);
- EXPECT_EQ(CallbackStatus::SUCCESS,
- GetStateAndWaitForResponse(manager_.get()));
- state.status = media_perception::STATUS_SUSPENDED;
- EXPECT_EQ(CallbackStatus::SUCCESS,
- SetStateAndWaitForResponse(manager_.get(), state));
-}
-
-TEST_F(MediaPerceptionAPIManagerTest, MediaAnalyticsDbusError) {
- media_perception::State state;
- state.status = media_perception::STATUS_RUNNING;
- EXPECT_EQ(CallbackStatus::SUCCESS,
- SetStateAndWaitForResponse(manager_.get(), state));
- // Disable the functionality of the fake process.
- media_analytics_client_->set_process_running(false);
- EXPECT_EQ(CallbackStatus::DBUS_ERROR,
- GetStateAndWaitForResponse(manager_.get()));
- EXPECT_EQ(CallbackStatus::DBUS_ERROR,
- SetStateAndWaitForResponse(manager_.get(), state));
-}
-
-} // namespace extensions

Powered by Google App Engine
This is Rietveld 408576698