Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(486)

Side by Side Diff: chrome/browser/ui/chrome_pages.cc

Issue 2899223002: [MD Bookmarks] Fix singleton tab behavior. (Closed)
Patch Set: mark histogram obsolete Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/ui/chrome_pages.h" 5 #include "chrome/browser/ui/chrome_pages.h"
6 6
7 #include <stddef.h> 7 #include <stddef.h>
8 8
9 #include "base/command_line.h" 9 #include "base/command_line.h"
10 #include "base/feature_list.h" 10 #include "base/feature_list.h"
11 #include "base/logging.h" 11 #include "base/logging.h"
12 #include "base/macros.h" 12 #include "base/macros.h"
13 #include "base/metrics/user_metrics.h" 13 #include "base/metrics/user_metrics.h"
14 #include "base/strings/string_number_conversions.h" 14 #include "base/strings/string_number_conversions.h"
15 #include "base/strings/stringprintf.h" 15 #include "base/strings/stringprintf.h"
16 #include "build/build_config.h" 16 #include "build/build_config.h"
17 #include "chrome/browser/bookmarks/bookmark_model_factory.h"
17 #include "chrome/browser/download/download_shelf.h" 18 #include "chrome/browser/download/download_shelf.h"
18 #include "chrome/browser/extensions/launch_util.h" 19 #include "chrome/browser/extensions/launch_util.h"
19 #include "chrome/browser/profiles/profile.h" 20 #include "chrome/browser/profiles/profile.h"
20 #include "chrome/browser/profiles/profile_manager.h" 21 #include "chrome/browser/profiles/profile_manager.h"
21 #include "chrome/browser/ui/browser.h" 22 #include "chrome/browser/ui/browser.h"
22 #include "chrome/browser/ui/browser_finder.h" 23 #include "chrome/browser/ui/browser_finder.h"
23 #include "chrome/browser/ui/browser_navigator_params.h" 24 #include "chrome/browser/ui/browser_navigator_params.h"
24 #include "chrome/browser/ui/browser_window.h" 25 #include "chrome/browser/ui/browser_window.h"
25 #include "chrome/browser/ui/extensions/app_launch_params.h" 26 #include "chrome/browser/ui/extensions/app_launch_params.h"
26 #include "chrome/browser/ui/extensions/application_launch.h" 27 #include "chrome/browser/ui/extensions/application_launch.h"
27 #include "chrome/browser/ui/scoped_tabbed_browser_displayer.h" 28 #include "chrome/browser/ui/scoped_tabbed_browser_displayer.h"
28 #include "chrome/browser/ui/settings_window_manager.h" 29 #include "chrome/browser/ui/settings_window_manager.h"
29 #include "chrome/browser/ui/singleton_tabs.h" 30 #include "chrome/browser/ui/singleton_tabs.h"
30 #include "chrome/browser/ui/tabs/tab_strip_model.h" 31 #include "chrome/browser/ui/tabs/tab_strip_model.h"
32 #include "chrome/browser/ui/webui/md_bookmarks/md_bookmarks_ui.h"
31 #include "chrome/browser/ui/webui/options/content_settings_handler.h" 33 #include "chrome/browser/ui/webui/options/content_settings_handler.h"
32 #include "chrome/browser/ui/webui/site_settings_helper.h" 34 #include "chrome/browser/ui/webui/site_settings_helper.h"
33 #include "chrome/common/chrome_features.h" 35 #include "chrome/common/chrome_features.h"
34 #include "chrome/common/chrome_switches.h" 36 #include "chrome/common/chrome_switches.h"
35 #include "chrome/common/url_constants.h" 37 #include "chrome/common/url_constants.h"
38 #include "components/bookmarks/browser/bookmark_model.h"
39 #include "components/bookmarks/browser/bookmark_node.h"
36 #include "components/signin/core/browser/signin_header_helper.h" 40 #include "components/signin/core/browser/signin_header_helper.h"
37 #include "components/signin/core/common/profile_management_switches.h" 41 #include "components/signin/core/common/profile_management_switches.h"
38 #include "content/public/browser/web_contents.h" 42 #include "content/public/browser/web_contents.h"
39 #include "extensions/browser/extension_prefs.h" 43 #include "extensions/browser/extension_prefs.h"
40 #include "extensions/common/constants.h" 44 #include "extensions/common/constants.h"
41 #include "google_apis/gaia/gaia_urls.h" 45 #include "google_apis/gaia/gaia_urls.h"
42 #include "net/base/url_util.h" 46 #include "net/base/url_util.h"
43 #include "ui/base/window_open_disposition.h" 47 #include "ui/base/window_open_disposition.h"
44 48
45 #if defined(OS_WIN) 49 #if defined(OS_WIN)
(...skipping 14 matching lines...) Expand all
60 #include "components/signin/core/browser/signin_manager.h" 64 #include "components/signin/core/browser/signin_manager.h"
61 #endif 65 #endif
62 66
63 using base::UserMetricsAction; 67 using base::UserMetricsAction;
64 68
65 namespace chrome { 69 namespace chrome {
66 namespace { 70 namespace {
67 71
68 const char kHashMark[] = "#"; 72 const char kHashMark[] = "#";
69 73
70 void OpenBookmarkManagerWithHash(Browser* browser, 74 void OpenBookmarkManagerForNode(Browser* browser, int64_t node_id) {
71 const std::string& action, 75 GURL url = GURL(kChromeUIBookmarksURL)
72 int64_t node_id) { 76 .Resolve(base::StringPrintf(
73 base::RecordAction(UserMetricsAction("ShowBookmarkManager")); 77 MdBookmarksUI::IsEnabled() ? "/?id=%s" : "/#%s",
74 base::RecordAction(UserMetricsAction("ShowBookmarks")); 78 base::Int64ToString(node_id).c_str()));
75 NavigateParams params(GetSingletonTabNavigateParams( 79 NavigateParams params(GetSingletonTabNavigateParams(browser, url));
76 browser,
77 GURL(kChromeUIBookmarksURL).Resolve(base::StringPrintf(
78 "/#%s%s", action.c_str(), base::Int64ToString(node_id).c_str()))));
79 params.path_behavior = NavigateParams::IGNORE_AND_NAVIGATE; 80 params.path_behavior = NavigateParams::IGNORE_AND_NAVIGATE;
80 ShowSingletonTabOverwritingNTP(browser, params); 81 ShowSingletonTabOverwritingNTP(browser, params);
81 } 82 }
82 83
83 void NavigateToSingletonTab(Browser* browser, const GURL& url) { 84 void NavigateToSingletonTab(Browser* browser, const GURL& url) {
84 NavigateParams params(GetSingletonTabNavigateParams(browser, url)); 85 NavigateParams params(GetSingletonTabNavigateParams(browser, url));
85 params.path_behavior = NavigateParams::IGNORE_AND_NAVIGATE; 86 params.path_behavior = NavigateParams::IGNORE_AND_NAVIGATE;
86 ShowSingletonTabOverwritingNTP(browser, params); 87 ShowSingletonTabOverwritingNTP(browser, params);
87 } 88 }
88 89
(...skipping 89 matching lines...) Expand 10 before | Expand all | Expand 10 after
178 std::string GenerateContentSettingsSearchQueryPath(int query_message_id) { 179 std::string GenerateContentSettingsSearchQueryPath(int query_message_id) {
179 return std::string(chrome::kDeprecatedOptionsSearchSubPage) + kHashMark + 180 return std::string(chrome::kDeprecatedOptionsSearchSubPage) + kHashMark +
180 l10n_util::GetStringUTF8(query_message_id); 181 l10n_util::GetStringUTF8(query_message_id);
181 } 182 }
182 #endif 183 #endif
183 184
184 } // namespace 185 } // namespace
185 186
186 void ShowBookmarkManager(Browser* browser) { 187 void ShowBookmarkManager(Browser* browser) {
187 base::RecordAction(UserMetricsAction("ShowBookmarkManager")); 188 base::RecordAction(UserMetricsAction("ShowBookmarkManager"));
188 base::RecordAction(UserMetricsAction("ShowBookmarks")); 189 if (MdBookmarksUI::IsEnabled()) {
190 const bookmarks::BookmarkNode* bookmark_bar_node =
191 BookmarkModelFactory::GetForBrowserContext(browser->profile())
192 ->bookmark_bar_node();
193 OpenBookmarkManagerForNode(browser, bookmark_bar_node->id());
194 return;
195 }
196
189 ShowSingletonTabOverwritingNTP( 197 ShowSingletonTabOverwritingNTP(
190 browser, 198 browser,
191 GetSingletonTabNavigateParams(browser, GURL(kChromeUIBookmarksURL))); 199 GetSingletonTabNavigateParams(browser, GURL(kChromeUIBookmarksURL)));
192 } 200 }
193 201
194 void ShowBookmarkManagerForNode(Browser* browser, int64_t node_id) { 202 void ShowBookmarkManagerForNode(Browser* browser, int64_t node_id) {
195 OpenBookmarkManagerWithHash(browser, std::string(), node_id); 203 base::RecordAction(UserMetricsAction("ShowBookmarkManager"));
204 OpenBookmarkManagerForNode(browser, node_id);
196 } 205 }
197 206
198 void ShowHistory(Browser* browser) { 207 void ShowHistory(Browser* browser) {
199 base::RecordAction(UserMetricsAction("ShowHistory")); 208 base::RecordAction(UserMetricsAction("ShowHistory"));
200 NavigateParams params( 209 NavigateParams params(
201 GetSingletonTabNavigateParams(browser, GURL(kChromeUIHistoryURL))); 210 GetSingletonTabNavigateParams(browser, GURL(kChromeUIHistoryURL)));
202 params.path_behavior = NavigateParams::IGNORE_AND_NAVIGATE; 211 params.path_behavior = NavigateParams::IGNORE_AND_NAVIGATE;
203 ShowSingletonTabOverwritingNTP(browser, params); 212 ShowSingletonTabOverwritingNTP(browser, params);
204 } 213 }
205 214
(...skipping 248 matching lines...) Expand 10 before | Expand all | Expand 10 after
454 SigninManagerFactory::GetForProfile(original_profile); 463 SigninManagerFactory::GetForProfile(original_profile);
455 DCHECK(manager->IsSigninAllowed()); 464 DCHECK(manager->IsSigninAllowed());
456 if (manager->IsAuthenticated()) 465 if (manager->IsAuthenticated())
457 ShowSettings(browser); 466 ShowSettings(browser);
458 else 467 else
459 ShowBrowserSignin(browser, access_point); 468 ShowBrowserSignin(browser, access_point);
460 } 469 }
461 #endif 470 #endif
462 471
463 } // namespace chrome 472 } // namespace chrome
OLDNEW
« no previous file with comments | « chrome/browser/ui/bookmarks/bookmark_context_menu_controller.cc ('k') | tools/metrics/actions/actions.xml » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698