Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3357)

Unified Diff: chrome/browser/ui/views/frame/browser_view_unittest.cc

Issue 2899133004: Reduce overdraw on bookmark bar (Closed)
Patch Set: revert change in browserview Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/ui/views/frame/browser_view_layout.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/views/frame/browser_view_unittest.cc
diff --git a/chrome/browser/ui/views/frame/browser_view_unittest.cc b/chrome/browser/ui/views/frame/browser_view_unittest.cc
index a12611cab6598bcfd77902c1ffe5b746e20e7b90..3a139124f6b8c6eeb8ccfd8d9120590262f70c12 100644
--- a/chrome/browser/ui/views/frame/browser_view_unittest.cc
+++ b/chrome/browser/ui/views/frame/browser_view_unittest.cc
@@ -140,17 +140,10 @@ TEST_F(BrowserViewTest, BrowserViewLayout) {
// Bookmark bar layout on NTP.
EXPECT_EQ(0, bookmark_bar->x());
- EXPECT_EQ(tabstrip->bounds().bottom() + toolbar->height() -
- views::NonClientFrameView::kClientEdgeThickness,
- bookmark_bar->y());
+ EXPECT_EQ(tabstrip->bounds().bottom() + toolbar->height(), bookmark_bar->y());
EXPECT_EQ(toolbar->bounds().bottom(), contents_container->y());
- // Contents view has a "top margin" pushing it below the bookmark bar.
- EXPECT_EQ(bookmark_bar->height() -
- views::NonClientFrameView::kClientEdgeThickness,
- devtools_web_view->y());
- EXPECT_EQ(bookmark_bar->height() -
- views::NonClientFrameView::kClientEdgeThickness,
- contents_web_view->y());
+ EXPECT_EQ(bookmark_bar->height(), devtools_web_view->y());
+ EXPECT_EQ(bookmark_bar->height(), contents_web_view->y());
// Bookmark bar is parented back to top container on normal page.
NavigateAndCommitActiveTabWithTitle(browser,
« no previous file with comments | « chrome/browser/ui/views/frame/browser_view_layout.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698