chrome/browser/ui/cocoa/browser_window_cocoa.mm - Issue 2899133004: Reduce overdraw on bookmark bar

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/cocoa/browser_window_cocoa.mm

Issue 2899133004: Reduce overdraw on bookmark bar (Closed)

Patch Set: revert change in browserview Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/ui/cocoa/browser_window_cocoa.mm

diff --git a/chrome/browser/ui/cocoa/browser_window_cocoa.mm b/chrome/browser/ui/cocoa/browser_window_cocoa.mm

index cb61d3af6005e2ad44f892a715b96ef87d1d62c1..2102f3b6d14c7ff01ffc9d6ae5f2510a3b9c69b1 100644

--- a/chrome/browser/ui/cocoa/browser_window_cocoa.mm

+++ b/chrome/browser/ui/cocoa/browser_window_cocoa.mm

@@ -22,6 +22,7 @@

#include "chrome/browser/shell_integration.h"

#include "chrome/browser/signin/chrome_signin_helper.h"

#include "chrome/browser/translate/chrome_translate_client.h"

+#include "chrome/browser/ui/bookmarks/bookmark_bar_constants.h"

#include "chrome/browser/ui/browser.h"

#include "chrome/browser/ui/browser_command_controller.h"

#include "chrome/browser/ui/browser_commands.h"

@@ -844,7 +845,7 @@ int

BrowserWindowCocoa::GetRenderViewHeightInsetWithDetachedBookmarkBar() {

if (browser_->bookmark_bar_state() != BookmarkBar::DETACHED)

return 0;

- return 40;

+ return chrome::kNTPBookmarkBarHeight;

}

void BrowserWindowCocoa::ExecuteExtensionCommand(