Reduce overdraw on bookmark bar

chrome/browser/ui/views/frame/browser_view.cc

 // Copyright 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/views/frame/browser_view.h"
 
 #include <stdint.h>
 
 #include <algorithm>
 #include <memory>
@@ skipping 182 matching lines @@
 // The number of milliseconds between loading animation frames.
 const int kLoadingAnimationFrameTimeMs = 30;
 
 // Paints the horizontal border separating the Bookmarks Bar from the Toolbar
 // or page content according to |at_top| with |color|.
 void PaintDetachedBookmarkBar(gfx::Canvas* canvas,
                               BookmarkBarView* view) {
   // Paint background for detached state; if animating, this is fade in/out.
   const ui::ThemeProvider* tp = view->GetThemeProvider();
   gfx::Rect fill_rect = view->GetLocalBounds();
-  // We have to not color the top 1dp, because that should be painted by the
-  // toolbar. We will, however, paint the 1px separator at the bottom of the
-  // first dp. See crbug.com/610359
-  fill_rect.Inset(0, 1, 0, 0);
 
   // In detached mode, the bar is meant to overlap with |contents_container_|.
   // The detached background color may be partially transparent, but the layer
   // for |view| must be painted opaquely to avoid subpixel anti-aliasing
   // artifacts, so we recreate the contents container base color here.
   canvas->FillRect(fill_rect,
                    tp->GetColor(ThemeProperties::COLOR_CONTROL_BACKGROUND));
   canvas->FillRect(
       fill_rect,
       tp->GetColor(ThemeProperties::COLOR_DETACHED_BOOKMARK_BAR_BACKGROUND));
@@ skipping 285 matching lines @@
   canvas->sk_canvas()->drawRect(gfx::RectFToSkRect(rect), flags);
 }
 
 void BrowserView::InitStatusBubble() {
   status_bubble_.reset(
       new StatusBubbleViews(contents_web_view_, HasClientEdge()));
   contents_web_view_->SetStatusBubble(status_bubble_.get());
 }
 
 gfx::Rect BrowserView::GetToolbarBounds() const {
-  gfx::Rect toolbar_bounds(toolbar_->bounds());
-  if (toolbar_bounds.IsEmpty())
-    return toolbar_bounds;
-  // The apparent toolbar edges are outside the "real" toolbar edges.
-  toolbar_bounds.Inset(-views::NonClientFrameView::kClientEdgeThickness, 0);

[Peter Kasting, 2017/05/31 02:16:03]

Can you explain why you removed this horizontal outdent?  Is it no longer needed
in the MD top chrome world, or did you mistake it for a vertical overlap, or
____?

[yiyix, 2017/06/01 21:13:55]

Sorry about it. I will pay more attention where I am replying. I will reply to
this comment to help you to be in context. 

I did more research on those lines. You are right! I have mistake it  for a
vertical overlap! I should not remove those lines! These insets are added to
draw the separator in between the tab and the toolbar in the right corner of the
browser (right to the tab strips). I have reverted them. Thank you so much!

@pkasting, could you please review this patch again? Thank you.

-  return toolbar_bounds;
+  return toolbar_->bounds();
 }
 
 gfx::Rect BrowserView::GetFindBarBoundingBox() const {
   return GetBrowserViewLayout()->GetFindBarBoundingBox();
 }
 
 int BrowserView::GetTabStripHeight() const {
   // We want to return tabstrip_->height(), but we might be called in the midst
   // of layout, when that hasn't yet been updated to reflect the current state.
   // So return what the tabstrip height _ought_ to be right now.
@@ skipping 2015 matching lines @@
 #endif
 }
 
 int BrowserView::GetRenderViewHeightInsetWithDetachedBookmarkBar() {
   if (browser_->bookmark_bar_state() != BookmarkBar::DETACHED ||
       !bookmark_bar_view_ || !bookmark_bar_view_->IsDetached()) {
     return 0;
   }
   // Don't use bookmark_bar_view_->height() which won't be the final height if
   // the bookmark bar is animating.
-  return chrome::kNTPBookmarkBarHeight -
-         views::NonClientFrameView::kClientEdgeThickness;
+  return chrome::kNTPBookmarkBarHeight;
 }
 
 void BrowserView::ExecuteExtensionCommand(
     const extensions::Extension* extension,
     const extensions::Command& command) {
   extension_keybinding_registry_->ExecuteCommand(extension->id(),
                                                  command.accelerator());
 }
 
 ExclusiveAccessContext* BrowserView::GetExclusiveAccessContext() {
@@ skipping 127 matching lines @@
 }
 
 extensions::ActiveTabPermissionGranter*
 BrowserView::GetActiveTabPermissionGranter() {
   content::WebContents* web_contents = GetActiveWebContents();
   if (!web_contents)
     return nullptr;
   return extensions::TabHelper::FromWebContents(web_contents)
       ->active_tab_permission_granter();
 }