[devil] Allow instantiation of AdbWrapper with USB bus identifer.

devil/devil/android/sdk/adb_wrapper.py

 # Copyright 2013 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 """This module wraps Android's adb tool.
 
 This is a thin wrapper around the adb interface. Any additional complexity
 should be delegated to a higher level (ex. DeviceUtils).
 """
 
@@ skipping 94 matching lines @@
 
   Args:
       line: Output line to check.
       send_cmd: Command that was sent to adb persistent shell.
   """
   return send_cmd.rstrip() in line
 
 
 class AdbWrapper(object):
   """A wrapper around a local Android Debug Bridge executable."""
 

[rnephew (Reviews Here), 2017/05/30 18:21:12]

Warning should be moved up here, not in the args section. 

[kavefish, 2017/05/30 19:27:20]

I was following perezju's suggestion here:
https://codereview.chromium.org/2899093002/diff/1/devil/devil/android/sdk/adb...

I'll relocate...

[rnephew (Reviews Here), 2017/05/30 19:40:32]

If Juan said that is the correct place, its fine there then. I have high
confidence in him being correct. 
The TODO should probably still be moved though.

   _adb_path = lazy.WeakConstant(_FindAdb)
   _adb_version = lazy.WeakConstant(_GetVersion)
 
   def __init__(self, device_serial):
     """Initializes the AdbWrapper.
 
     Args:
-      device_serial: The device serial number as a string.
+      device_serial: The device serial number or USB bus ID (*) as a string.
+
+      # (*) WARNING: Not all devil features are supported when using a USB ID.

[rnephew (Reviews Here), 2017/05/30 18:21:12]

I'm wondering if we can detect if we suspect that the user is using a USB Id and
output this warning there. Not necessarily in this CL, but just a thought. 

[kavefish, 2017/05/30 19:27:20]

That's interesting. Detection should be straightforward because all USB ids
start with the string "usb:".

I took a stab at a warning. 

+
+      # TODO: Improve support for instances created from a USB ID.
+
     """
     if not device_serial:

[rnephew (Reviews Here), 2017/05/30 18:21:12]

TODO should be moved here outside the class level documentation.

       raise ValueError('A device serial must be specified')
     self._device_serial = str(device_serial)
 
   class PersistentShell(object):
     '''Class to use persistent shell for ADB.
 
     This class allows a persistent ADB shell to be created, where multiple
     commands can be passed into it. This avoids the overhead of starting
     up a new ADB shell for each command.
 
@@ skipping 681 matching lines @@
     self._RunDeviceAdbCmd(['wait-for-device'], timeout, retries)
 
   def GetState(self, timeout=DEFAULT_TIMEOUT, retries=DEFAULT_RETRIES):
     """Get device state.
 
     Args:
       timeout: (optional) Timeout per try in seconds.
       retries: (optional) Number of retries to attempt.
 
     Returns:
-      One of 'offline', 'bootloader', or 'device'.
+        One of 'offline', 'bootloader', or 'unauthorized', or
+        'no' [permissions], or 'device'
     """
     # TODO(jbudorick): Revert to using get-state once it doesn't cause a
     # a protocol fault.
     # return self._RunDeviceAdbCmd(['get-state'], timeout, retries).strip()
 
-    lines = self._RawDevices(timeout=timeout, retries=retries)
+    lines = self._RawDevices(timeout=timeout, retries=retries, long_list=True)
     for line in lines:
-      if len(line) >= 2 and line[0] == self._device_serial:
+      if len(line) >= 3 and (line[0] == self._device_serial or line[2] ==
+        self._device_serial):
         return line[1]
     return 'offline'
 
   def GetDevPath(self, timeout=DEFAULT_TIMEOUT, retries=DEFAULT_RETRIES):
     """Gets the device path.
 
     Args:
       timeout: (optional) Timeout per try in seconds.
       retries: (optional) Number of retries to attempt.
 
@@ skipping 68 matching lines @@
   @property
   def is_emulator(self):
     return _EMULATOR_RE.match(self._device_serial)
 
   @property
   def is_ready(self):
     try:
       return self.GetState() == _READY_STATE
     except device_errors.CommandFailedError:
       return False