Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(74)

Issue 2899083007: Update DDC html libraries to match SDK (Closed)

Created:
3 years, 7 months ago by Alan Knight
Modified:
3 years, 7 months ago
Reviewers:
vsm, terry, Jacob
CC:
dev-compiler+reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+7703 lines, -3510 lines) Patch
M pkg/dev_compiler/lib/sdk/ddc_sdk.sum View Binary file 0 comments Download
M pkg/dev_compiler/test/browser/language_tests.js View 2 chunks +1 line, -2 lines 0 comments Download
M pkg/dev_compiler/test/not_yet_strong_tests.dart View 1 chunk +0 lines, -1 line 0 comments Download
M pkg/dev_compiler/tool/input_sdk/lib/html/dart2js/html_dart2js.dart View 372 chunks +3392 lines, -1777 lines 0 comments Download
M pkg/dev_compiler/tool/input_sdk/lib/indexed_db/dart2js/indexed_db_dart2js.dart View 6 chunks +6 lines, -6 lines 0 comments Download
M pkg/dev_compiler/tool/input_sdk/lib/svg/dart2js/svg_dart2js.dart View 18 chunks +214 lines, -1028 lines 0 comments Download
M pkg/dev_compiler/tool/input_sdk/lib/web_audio/dart2js/web_audio_dart2js.dart View 14 chunks +134 lines, -41 lines 0 comments Download
M pkg/dev_compiler/tool/input_sdk/lib/web_gl/dart2js/web_gl_dart2js.dart View 50 chunks +3835 lines, -493 lines 0 comments Download
M pkg/dev_compiler/tool/input_sdk/lib/web_sql/dart2js/web_sql_dart2js.dart View 4 chunks +11 lines, -5 lines 0 comments Download
M pkg/dev_compiler/tool/sdk_expected_errors.txt View 1 chunk +82 lines, -85 lines 1 comment Download
M tests/lib_strong/html/debugger_test_golden.txt View 3 chunks +28 lines, -72 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
Alan Knight
3 years, 7 months ago (2017-05-24 23:36:44 UTC) #2
Alan Knight
3 years, 7 months ago (2017-05-24 23:46:28 UTC) #4
vsm
lgtm https://codereview.chromium.org/2899083007/diff/1/pkg/dev_compiler/tool/sdk_expected_errors.txt File pkg/dev_compiler/tool/sdk_expected_errors.txt (left): https://codereview.chromium.org/2899083007/diff/1/pkg/dev_compiler/tool/sdk_expected_errors.txt#oldcode4 pkg/dev_compiler/tool/sdk_expected_errors.txt:4: [error] A value of type 'Dimension' can't be ...
3 years, 7 months ago (2017-05-25 13:12:01 UTC) #5
Alan Knight
3 years, 7 months ago (2017-05-25 16:33:35 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
0bb2d5e548e8ab40374f64a37c5951905215b0b5 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698