Use declared return type for inference of return and yield statements.

Use declared return type for inference of return and yield statements.

R=ahe@google.com

Committed: https://github.com/dart-lang/sdk/commit/6b100c007b68ea7442870bc584903b6d61dfe0aa

[Paul Berry, 2017-05-24 15:31:36]

paulberry@google.com changed reviewers:
+ ahe@google.com, scheglov@google.com

[Paul Berry, 2017-05-24 15:31:36]

Peter, I had to do some work to plumb the FunctionNode through to the
BodyBuilder so that it would have access to the declared return type.  Let me
know if there's a better way to go about this.

[ahe, 2017-05-24 15:36:40]

lgtm

https://codereview.chromium.org/2899073004/diff/1/pkg/front_end/lib/src/fasta...
File pkg/front_end/lib/src/fasta/builder/procedure_builder.dart (right):

https://codereview.chromium.org/2899073004/diff/1/pkg/front_end/lib/src/fasta...
pkg/front_end/lib/src/fasta/builder/procedure_builder.dart:10: import
'package:kernel/ast.dart' show AsyncMarker, FunctionNode, ProcedureKind;
Could you move this to KernelProcedureBuilder?

[ahe, 2017-05-24 15:52:04]

Actually, I'm having some second thoughts about this. Details will follow
shortly.

[ahe, 2017-05-24 16:00:22]

https://codereview.chromium.org/2899073004/diff/1/pkg/front_end/lib/src/fasta...
File pkg/front_end/lib/src/fasta/kernel/body_builder.dart (right):

https://codereview.chromium.org/2899073004/diff/1/pkg/front_end/lib/src/fasta...
pkg/front_end/lib/src/fasta/kernel/body_builder.dart:484: AsyncMarker
asyncModifier, Statement body) {
You can access FunctionNode like this:

member.target.function

This way, you can probably avoid most of the changes in this CL?

[ahe, 2017-05-24 16:01:12]

To be clear: I'm not withdrawing my LGTM :-)

[Paul Berry, 2017-05-24 16:20:16]

Thanks for your help, Peter.  I will land shortly, after I've re-run tests

https://codereview.chromium.org/2899073004/diff/1/pkg/front_end/lib/src/fasta...
File pkg/front_end/lib/src/fasta/builder/procedure_builder.dart (right):

https://codereview.chromium.org/2899073004/diff/1/pkg/front_end/lib/src/fasta...
pkg/front_end/lib/src/fasta/builder/procedure_builder.dart:10: import
'package:kernel/ast.dart' show AsyncMarker, FunctionNode, ProcedureKind;
On 2017/05/24 15:36:39, ahe wrote:
> Could you move this to KernelProcedureBuilder?

Acknowledged.  In light of your other suggestion, this change goes away.

https://codereview.chromium.org/2899073004/diff/1/pkg/front_end/lib/src/fasta...
File pkg/front_end/lib/src/fasta/kernel/body_builder.dart (right):

https://codereview.chromium.org/2899073004/diff/1/pkg/front_end/lib/src/fasta...
pkg/front_end/lib/src/fasta/kernel/body_builder.dart:484: AsyncMarker
asyncModifier, Statement body) {
On 2017/05/24 16:00:21, ahe wrote:
> You can access FunctionNode like this:
> 
> member.target.function
> 
> This way, you can probably avoid most of the changes in this CL?

Yes, that worked!  Thank you, that makes this CL much less invasive.

[Paul Berry, 2017-05-24 16:28:31]

Description was changed from

==========
Use declared return type for inference of return and yield statements.
==========

to

==========
Use declared return type for inference of return and yield statements.

R=ahe@google.com

Committed:
https://github.com/dart-lang/sdk/commit/6b100c007b68ea7442870bc584903b6d61dfe0aa
==========

[Paul Berry, 2017-05-24 16:28:32]

Committed patchset #2 (id:20001) manually as
6b100c007b68ea7442870bc584903b6d61dfe0aa (presubmit successful).

[scheglov, 2017-05-24 16:38:14]

LGTM