ui/views/win/hwnd_message_handler.cc - Issue 2899053007: Don't do DefWindowProc on WM_NCACTIVATE if there's no frame.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ui/views/win/hwnd_message_handler.cc

Issue 2899053007: Don't do DefWindowProc on WM_NCACTIVATE if there's no frame. (Closed)

Patch Set: Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: ui/views/win/hwnd_message_handler.cc

diff --git a/ui/views/win/hwnd_message_handler.cc b/ui/views/win/hwnd_message_handler.cc

index de7223ccbe729e6ac7a3b45c92ffc8b72de1fb94..619dcacb13e1b246a9997f6009b0f040c6c78c7d 100644

--- a/ui/views/win/hwnd_message_handler.cc

+++ b/ui/views/win/hwnd_message_handler.cc

@@ -1819,7 +1819,8 @@ LRESULT HWNDMessageHandler::OnNCActivate(UINT message,

if (IsVisible())

delegate_->SchedulePaint();

- if (delegate_->GetFrameMode() == FrameMode::CUSTOM_DRAWN) {

+ if (!delegate_->HasFrame() ||

+ (delegate_->GetFrameMode() == FrameMode::CUSTOM_DRAWN)) {

Bret 2017/05/24 22:22:05 nit: you don't need parens around this clause

SetMsgHandled(TRUE);

return TRUE;

}

« no previous file with comments | « no previous file | no next file » | no next file with comments »