[Home] Ensure incognito tab model is created when NTP opened

chrome/android/java/src/org/chromium/chrome/browser/ChromeTabbedActivity.java

Index: chrome/android/java/src/org/chromium/chrome/browser/ChromeTabbedActivity.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/ChromeTabbedActivity.java b/chrome/android/java/src/org/chromium/chrome/browser/ChromeTabbedActivity.java
index 4a857b1a9c4a807aa7251adafae7c07af2404407..0aa92d9a380f8f77efc0bd9f97a8abc56926efd7 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/ChromeTabbedActivity.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/ChromeTabbedActivity.java
@@ -1034,11 +1034,14 @@ public class ChromeTabbedActivity extends ChromeActivity implements OverviewMode
             }
 
             if (getBottomSheet() != null) {
-                if (getBottomSheet().isShowingNewTab()) {
+                // If the bottom sheet new tab UI is showing and the tab open type is not
+                // already OPEN_NEW_TAB or OPEN_NEW_INCOGNITO_TAB, set the open type so that a real
+                // new tab will be created and added to the appropriate model.
+                if (getBottomSheet().isShowingNewTab() && tabOpenType != TabOpenType.OPEN_NEW_TAB
+                        && tabOpenType != TabOpenType.OPEN_NEW_INCOGNITO_TAB) {
                     tabOpenType = mTabModelSelectorImpl.isIncognitoSelected()
                             ? TabOpenType.OPEN_NEW_INCOGNITO_TAB
                             : TabOpenType.OPEN_NEW_TAB;
-                    getBottomSheet().onProcessUrlViewIntent();

[Theresa, 2017/05/24 16:52:08]

BottomSheetNewTabController hides the new tab UI when the sheet is closed (which
happens on 1048), so there's no need for this call.

                 }
 
                 // Either a new tab is opening, a tab is being clobbered, or a tab is being brought