Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(64)

Unified Diff: chrome/android/javatests/src/org/chromium/chrome/browser/widget/bottomsheet/BottomSheetNewTabControllerTest.java

Issue 2899053004: [Home] Ensure incognito tab model is created when NTP opened (Closed)
Patch Set: Close bottom sheet after loading URL/opening new tab Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/android/javatests/src/org/chromium/chrome/browser/tabmodel/document/MockDocumentTabModel.java ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/android/javatests/src/org/chromium/chrome/browser/widget/bottomsheet/BottomSheetNewTabControllerTest.java
diff --git a/chrome/android/javatests/src/org/chromium/chrome/browser/widget/bottomsheet/BottomSheetNewTabControllerTest.java b/chrome/android/javatests/src/org/chromium/chrome/browser/widget/bottomsheet/BottomSheetNewTabControllerTest.java
index c9ad79e63f87e2a48191be2ceec716dcea97f821..96abc93104f99248eff94966ec5a6810b9742d35 100644
--- a/chrome/android/javatests/src/org/chromium/chrome/browser/widget/bottomsheet/BottomSheetNewTabControllerTest.java
+++ b/chrome/android/javatests/src/org/chromium/chrome/browser/widget/bottomsheet/BottomSheetNewTabControllerTest.java
@@ -73,7 +73,7 @@ public class BottomSheetNewTabControllerTest extends BottomSheetTestCaseBase {
ThreadUtils.runOnUiThreadBlocking(new Runnable() {
@Override
public void run() {
- mBottomSheet.loadUrl(new LoadUrlParams("about:blank"), false);
+ mBottomSheet.loadUrlInNewTab(new LoadUrlParams("about:blank"));
}
});
@@ -95,7 +95,6 @@ public class BottomSheetNewTabControllerTest extends BottomSheetTestCaseBase {
// Select "New incognito tab" from the menu.
MenuUtils.invokeCustomMenuActionSync(
getInstrumentation(), getActivity(), R.id.new_incognito_tab_menu_id);
-
// The sheet should be opened at half height over the tab switcher and the tab count should
// remain unchanged. The incognito model should now be selected.
validateState(false, BottomSheet.SHEET_STATE_HALF);
@@ -115,7 +114,7 @@ public class BottomSheetNewTabControllerTest extends BottomSheetTestCaseBase {
ThreadUtils.runOnUiThreadBlocking(new Runnable() {
@Override
public void run() {
- mBottomSheet.loadUrl(new LoadUrlParams("about:blank"), true);
+ mBottomSheet.loadUrlInNewTab(new LoadUrlParams("about:blank"));
}
});
« no previous file with comments | « chrome/android/javatests/src/org/chromium/chrome/browser/tabmodel/document/MockDocumentTabModel.java ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698