Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2899043006: cleanup fasta token classes (Closed)

Created:
3 years, 7 months ago by danrubel
Modified:
3 years, 6 months ago
Reviewers:
ahe, scheglov
CC:
reviews_dartlang.org, dart-fe-team+reviews_google.com
Target Ref:
refs/heads/master
Visibility:
Public.

Description

cleanup fasta token classes * replace fasta.SymbolToken --> analyzer.Token * replace fasta.BeginGroupToken --> analyzer.BeginToken * replace fasta.SymbolToken.eof --> analyzer.Token.eof R=scheglov@google.com Committed: https://github.com/dart-lang/sdk/commit/54d6e3a1c5b4a08e2c48eb4271e082014798b80e

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+219 lines, -265 lines) Patch
M pkg/analyzer/lib/src/dart/ast/utilities.dart View 1 chunk +1 line, -2 lines 0 comments Download
M pkg/analyzer/lib/src/fasta/ast_builder.dart View 5 chunks +5 lines, -6 lines 0 comments Download
M pkg/analyzer/lib/src/fasta/token_utils.dart View 2 chunks +1 line, -3 lines 0 comments Download
M pkg/analyzer/lib/src/generated/parser.dart View 4 chunks +4 lines, -8 lines 0 comments Download
M pkg/analyzer/lib/src/summary/fasta/stack_listener.dart View 2 chunks +4 lines, -2 lines 0 comments Download
M pkg/compiler/lib/src/native/resolver.dart View 2 chunks +3 lines, -3 lines 0 comments Download
M pkg/compiler/lib/src/native/scanner.dart View 2 chunks +3 lines, -2 lines 0 comments Download
M pkg/compiler/lib/src/parser/element_listener.dart View 3 chunks +4 lines, -3 lines 0 comments Download
M pkg/compiler/lib/src/parser/node_listener.dart View 2 chunks +2 lines, -3 lines 0 comments Download
M pkg/compiler/lib/src/resolution/enum_creator.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/compiler/lib/src/tree/nodes.dart View 2 chunks +4 lines, -4 lines 0 comments Download
M pkg/front_end/lib/src/fasta/kernel/body_builder.dart View 2 chunks +3 lines, -4 lines 0 comments Download
M pkg/front_end/lib/src/fasta/parser/listener.dart View 3 chunks +3 lines, -5 lines 0 comments Download
M pkg/front_end/lib/src/fasta/parser/parser.dart View 27 chunks +37 lines, -37 lines 0 comments Download
M pkg/front_end/lib/src/fasta/parser/token_stream_rewriter.dart View 3 chunks +3 lines, -5 lines 0 comments Download
M pkg/front_end/lib/src/fasta/scanner.dart View 1 chunk +0 lines, -2 lines 0 comments Download
M pkg/front_end/lib/src/fasta/scanner/abstract_scanner.dart View 5 chunks +9 lines, -9 lines 0 comments Download
M pkg/front_end/lib/src/fasta/scanner/array_based_scanner.dart View 9 chunks +20 lines, -13 lines 0 comments Download
M pkg/front_end/lib/src/fasta/scanner/error_token.dart View 4 chunks +5 lines, -6 lines 0 comments Download
M pkg/front_end/lib/src/fasta/scanner/recover.dart View 3 chunks +3 lines, -3 lines 0 comments Download
M pkg/front_end/lib/src/fasta/scanner/token.dart View 1 chunk +0 lines, -77 lines 0 comments Download
M pkg/front_end/lib/src/fasta/source/diet_listener.dart View 2 chunks +2 lines, -4 lines 0 comments Download
M pkg/front_end/lib/src/fasta/source/diet_parser.dart View 2 chunks +2 lines, -4 lines 0 comments Download
M pkg/front_end/lib/src/fasta/source/source_library_builder.dart View 2 chunks +1 line, -3 lines 0 comments Download
M pkg/front_end/lib/src/fasta/source/stack_listener.dart View 2 chunks +4 lines, -2 lines 0 comments Download
M pkg/front_end/lib/src/scanner/scanner.dart View 2 chunks +3 lines, -5 lines 0 comments Download
M pkg/front_end/lib/src/scanner/token.dart View 4 chunks +43 lines, -1 line 0 comments Download
M pkg/front_end/test/fasta/parser/token_stream_rewriter_test.dart View 3 chunks +6 lines, -5 lines 0 comments Download
M pkg/front_end/test/scanner_fasta_test.dart View 11 chunks +20 lines, -20 lines 0 comments Download
M pkg/front_end/test/scanner_replacement_test.dart View 9 chunks +21 lines, -20 lines 0 comments Download
M pkg/front_end/test/subpackage_relationships_test.dart View 1 chunk +0 lines, -1 line 0 comments Download
M pkg/front_end/test/token_test.dart View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
danrubel
3 years, 7 months ago (2017-05-25 02:59:22 UTC) #2
scheglov
LGTM
3 years, 7 months ago (2017-05-25 04:28:33 UTC) #3
danrubel
Committed patchset #1 (id:1) manually as 54d6e3a1c5b4a08e2c48eb4271e082014798b80e (presubmit successful).
3 years, 7 months ago (2017-05-25 11:26:56 UTC) #5
ahe
3 years, 6 months ago (2017-05-31 13:48:21 UTC) #6
Message was sent while issue was closed. 
lgtm

So nice when there's more deleted lines than added lines :-)

Powered by Google App Engine
This is Rietveld 408576698