Issue 289903008: Merge SingleThreadProxy::CommitAndComposite into CompositeImmediately.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 289903008: Merge SingleThreadProxy::CommitAndComposite into CompositeImmediately. (Closed)

Created:
6 years, 7 months ago by danakj

Modified:
6 years, 7 months ago

Reviewers:
enne (OOO)

CC:
chromium-reviews, cc-bugs_chromium.org, piman

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Merge SingleThreadProxy::CommitAndComposite into CompositeImmediately. There's only one caller of this method now that CompositeAndReadback is gone, so just inline the code to make things easier to read. R=enne@chromium.org, enne BUG=374287 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=271095

Created: 6 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+23 lines, -35 lines)			Patch
	M	cc/trees/single_thread_proxy.h	View		1 chunk	+0 lines, -2 lines	0 comments	Download
	M	cc/trees/single_thread_proxy.cc	View		2 chunks	+23 lines, -33 lines	0 comments	Download

Total messages: 5 (0 generated)

enne (OOO)

Sure, lgtm. I think my SingleThreadProxy / SchedulerClient patch also does this too.

6 years, 7 months ago (2014-05-16 18:05:16 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/danakj@chromium.org/289903008/1

6 years, 7 months ago (2014-05-16 18:09:16 UTC) #4

danakj

6 years, 7 months ago (2014-05-16 21:29:29 UTC) #5

Message was sent while issue was closed.

Committed patchset #1 manually as r271095 (presubmit successful).