Add ClosureClassMaps super interface for ClosureTask

Add ClosureClassMaps super interface for ClosureTask

With this change the empty program now runs until ssa/codegen.

R=efortuna@google.com, sigmund@google.com

Committed: https://github.com/dart-lang/sdk/commit/f7468ab088ff3c0a8a59a5fde22a7f9472a3293b

[Johnni Winther, 2017-05-24 14:09:08]

johnniwinther@google.com changed reviewers:
+ efortuna@google.com, sigmund@google.com

[Siggi Cherem (dart-lang), 2017-05-24 17:26:25]

lgtm

https://codereview.chromium.org/2898983005/diff/1/pkg/compiler/lib/src/kernel...
File pkg/compiler/lib/src/kernel/element_map_impl.dart (right):

https://codereview.chromium.org/2898983005/diff/1/pkg/compiler/lib/src/kernel...
pkg/compiler/lib/src/kernel/element_map_impl.dart:689: ir.Member
getMemberRoot(KMember member) {
what is a member root?

[Emily Fortuna, 2017-05-24 17:48:08]

lgtm. This is a little different from the changes I made, so I'll see how my
plans fit in with this.

https://codereview.chromium.org/2898983005/diff/1/pkg/compiler/lib/src/kernel...
File pkg/compiler/lib/src/kernel/element_map_impl.dart (right):

https://codereview.chromium.org/2898983005/diff/1/pkg/compiler/lib/src/kernel...
pkg/compiler/lib/src/kernel/element_map_impl.dart:689: ir.Member
getMemberRoot(KMember member) {
On 2017/05/24 17:26:25, Siggi Cherem (dart-lang) wrote:
> what is a member root?

+1

[Emily Fortuna, 2017-05-24 22:12:55]

https://codereview.chromium.org/2898983005/diff/1/pkg/compiler/lib/src/ssa/bu...
File pkg/compiler/lib/src/ssa/builder.dart (left):

https://codereview.chromium.org/2898983005/diff/1/pkg/compiler/lib/src/ssa/bu...
pkg/compiler/lib/src/ssa/builder.dart:1210:
closureToClassMapper.getClosureToClassMapping(resolvedAst);
why is this no longer necessary?

[Emily Fortuna, 2017-05-26 21:10:10]

On 2017/05/24 22:12:55, Emily Fortuna wrote:
>
https://codereview.chromium.org/2898983005/diff/1/pkg/compiler/lib/src/ssa/bu...
> File pkg/compiler/lib/src/ssa/builder.dart (left):
> 
>
https://codereview.chromium.org/2898983005/diff/1/pkg/compiler/lib/src/ssa/bu...
> pkg/compiler/lib/src/ssa/builder.dart:1210:
> closureToClassMapper.getClosureToClassMapping(resolvedAst);
> why is this no longer necessary?

Note: when I run all of this, the following two tests fail:
python tools/test.py -mrelease -cdart2js -rd8 --host-checked -t960
--dart2js-batch language/closure_in_initializer_test

python tools/test.py -mrelease -cdart2js -rd8 --host-checked -t960
--dart2js-batch language/constructor6_test

[Johnni Winther, 2017-05-29 08:17:41]

https://codereview.chromium.org/2898983005/diff/1/pkg/compiler/lib/src/kernel...
File pkg/compiler/lib/src/kernel/element_map_impl.dart (right):

https://codereview.chromium.org/2898983005/diff/1/pkg/compiler/lib/src/kernel...
pkg/compiler/lib/src/kernel/element_map_impl.dart:689: ir.Member
getMemberRoot(KMember member) {
On 2017/05/24 17:48:08, Emily Fortuna wrote:
> On 2017/05/24 17:26:25, Siggi Cherem (dart-lang) wrote:
> > what is a member root?
> 
> +1

Renamed to [getMemberNode] and added docs.

https://codereview.chromium.org/2898983005/diff/1/pkg/compiler/lib/src/ssa/bu...
File pkg/compiler/lib/src/ssa/builder.dart (left):

https://codereview.chromium.org/2898983005/diff/1/pkg/compiler/lib/src/ssa/bu...
pkg/compiler/lib/src/ssa/builder.dart:1210:
closureToClassMapper.getClosureToClassMapping(resolvedAst);
On 2017/05/24 22:12:55, Emily Fortuna wrote:
> why is this no longer necessary?

Long time ago [getClosureToClassMapping] would lazily compute the closure info
(thus needing the trigger here). Nowadays the closure info is computed up front
and this call will fail with an assertion error if it isn't the case.

[Johnni Winther, 2017-05-29 08:27:08]

Description was changed from

==========
Add ClosureClassMaps super interface for ClosureTask

With this change the empty program now runs until ssa/codegen.
==========

to

==========
Add ClosureClassMaps super interface for ClosureTask

With this change the empty program now runs until ssa/codegen.

R=efortuna@google.com, sigmund@google.com

Committed:
https://github.com/dart-lang/sdk/commit/f7468ab088ff3c0a8a59a5fde22a7f9472a3293b
==========

[Johnni Winther, 2017-05-29 08:27:09]

Committed patchset #2 (id:20001) manually as
f7468ab088ff3c0a8a59a5fde22a7f9472a3293b (presubmit successful).