net/cookies/canonical_cookie.h - Issue 2898953008: Implement and test CanonicalCookie::IsCanonical()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/cookies/canonical_cookie.h

Issue 2898953008: Implement and test CanonicalCookie::IsCanonical() (Closed)

Patch Set: Add test param to Android Webview cookie test. Created 3 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: net/cookies/canonical_cookie.h

diff --git a/net/cookies/canonical_cookie.h b/net/cookies/canonical_cookie.h

index a2b366ddd619724ffe63c3750db0077aeead6b00..6b08eda16fab6059ace23e056f1659ba6552f0f5 100644

--- a/net/cookies/canonical_cookie.h

+++ b/net/cookies/canonical_cookie.h

@@ -144,6 +144,10 @@ class NET_EXPORT CanonicalCookie {

// FullCompare() are also sorted with respect to PartialCompare().

bool FullCompare(const CanonicalCookie& other) const;

+ // Return whether this object is a valid CanonicalCookie(). Invalid

+ // cookies may be constructed by the detailed constructor.

+ bool IsCanonical() const;

private:

FRIEND_TEST_ALL_PREFIXES(CanonicalCookieTest, TestPrefixHistograms);