Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(109)

Issue 2898743003: Revert "Revert "Use Kernel frontend from run_vm_tests."" (Closed)

Created:
3 years, 7 months ago by aam
Modified:
3 years, 7 months ago
Reviewers:
siva
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Revert "Revert "Use Kernel frontend from run_vm_tests."" This reverts commit 530a0df8f336e5df610a1c783e4ee58530387beb. This relands https://codereview.chromium.org/2881953002/ that had to be reverted because it caused Dartium build regression. Now fix for Dartium build on mac is in place with Dartium order file update(https://codereview.chromium.org/2887183003) and corresponding Dartium DEPS rollforward(https://codereview.chromium.org/2888283003/). BUG=https://github.com/dart-lang/sdk/issues/28264 R=asiva@google.com Committed: https://github.com/dart-lang/sdk/commit/ddab610d534f92e55dcaa698c479bf14e3eca71a

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+259 lines, -40 lines) Patch
M runtime/bin/BUILD.gn View 1 chunk +4 lines, -0 lines 0 comments Download
M runtime/bin/run_vm_tests.cc View 5 chunks +130 lines, -21 lines 0 comments Download
M runtime/include/dart_api.h View 1 chunk +9 lines, -0 lines 0 comments Download
M runtime/vm/dart_api_impl.cc View 1 chunk +15 lines, -0 lines 0 comments Download
M runtime/vm/kernel_isolate.h View 1 chunk +4 lines, -1 line 0 comments Download
M runtime/vm/kernel_isolate.cc View 5 chunks +48 lines, -13 lines 0 comments Download
M runtime/vm/unit_test.cc View 3 chunks +49 lines, -5 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
aam
3 years, 7 months ago (2017-05-22 17:54:52 UTC) #3
siva
lgtm
3 years, 7 months ago (2017-05-22 21:23:53 UTC) #4
aam
3 years, 7 months ago (2017-05-22 22:00:35 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
ddab610d534f92e55dcaa698c479bf14e3eca71a (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698