Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1896)

Unified Diff: ash/app_list/app_list_presenter_delegate.cc

Issue 2898743002: Draggable peeking/fullscreen launcher with transparent background. (Closed)
Patch Set: adressed comments. Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | ash/app_list/app_list_presenter_delegate_unittest.cc » ('j') | ash/shelf/shelf.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ash/app_list/app_list_presenter_delegate.cc
diff --git a/ash/app_list/app_list_presenter_delegate.cc b/ash/app_list/app_list_presenter_delegate.cc
index 258a88d4903e4a7b8a6073e9559ac0ccb668cbca..8d4f4c94bcae4c71666cade7b14786845b9b4869 100644
--- a/ash/app_list/app_list_presenter_delegate.cc
+++ b/ash/app_list/app_list_presenter_delegate.cc
@@ -129,6 +129,14 @@ void AppListPresenterDelegate::OnShown(int64_t display_id) {
Shelf::ForWindow(root_window)->shelf_widget()->GetAppListButton();
if (app_list_button)
app_list_button->OnAppListShown();
+
+ // Notify the shelf that the app list is active so the backgrounds do not
+ // overlap.
+
+ if (app_list::features::IsFullscreenAppListEnabled()) {
xiyuan 2017/05/26 18:27:31 Can you replicate the logic in AppListDelegateImpl
newcomer 2017/05/26 23:20:21 Resolved offline, created Mustash bug.
+ Shelf* shelf = Shelf::ForWindow(root_window);
+ shelf->OnAppListIsActive(true);
+ }
}
void AppListPresenterDelegate::OnDismissed() {
@@ -142,6 +150,11 @@ void AppListPresenterDelegate::OnDismissed() {
AppListButton* app_list_button = shelf->shelf_widget()->GetAppListButton();
if (app_list_button)
app_list_button->OnAppListDismissed();
+ if (app_list::features::IsFullscreenAppListEnabled()) {
+ // Notify the shelf that the app list is being dismissed so it can
+ // re-enable its transparent background.
+ shelf->OnAppListIsActive(false);
+ }
}
void AppListPresenterDelegate::UpdateBounds() {
« no previous file with comments | « no previous file | ash/app_list/app_list_presenter_delegate_unittest.cc » ('j') | ash/shelf/shelf.h » ('J')

Powered by Google App Engine
This is Rietveld 408576698