Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(66)

Unified Diff: ash/app_list/app_list_delegate_impl.cc

Issue 2898743002: Draggable peeking/fullscreen launcher with transparent background. (Closed)
Patch Set: Addressed comments. Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ash/app_list/app_list_delegate_impl.cc
diff --git a/ash/app_list/app_list_delegate_impl.cc b/ash/app_list/app_list_delegate_impl.cc
index c8fbf0f0edde5c4af59d8358fb5f6e6c17f0016b..70b6c0efddb9b843d31c74428798a9eafc8c3383 100644
--- a/ash/app_list/app_list_delegate_impl.cc
+++ b/ash/app_list/app_list_delegate_impl.cc
@@ -11,6 +11,7 @@
#include "ash/shell.h"
#include "ash/shell_port.h"
#include "ash/wm_window.h"
+#include "ui/app_list/app_list_features.h"
#include "ui/app_list/presenter/app_list.h"
namespace ash {
@@ -32,10 +33,19 @@ void AppListDelegateImpl::OnAppListVisibilityChanged(bool visible,
if (!app_list_button)
return;
- if (visible)
+ if (visible) {
app_list_button->OnAppListShown();
- else
+ if (app_list::features::IsFullscreenAppListEnabled()) {
+ Shelf* shelf = Shelf::ForWindow(root_window);
+ shelf->OnAppListIsActive(true);
vadimt 2017/05/26 23:44:08 This repeated part can be moved to after if.
newcomer 2017/05/30 21:37:03 Done.
+ }
+ } else {
app_list_button->OnAppListDismissed();
+ if (app_list::features::IsFullscreenAppListEnabled()) {
+ Shelf* shelf = Shelf::ForWindow(root_window);
+ shelf->OnAppListIsActive(true);
xiyuan 2017/05/30 16:32:33 Should this be "false" ? We probably can use |visi
newcomer 2017/05/30 21:37:03 Correct, I noticed this too and It's fixed.
+ }
+ }
}
} // namespace ash
« no previous file with comments | « no previous file | ash/app_list/app_list_presenter_delegate.cc » ('j') | ash/app_list/app_list_presenter_delegate.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698