Draggable peeking/fullscreen launcher with transparent background.

ui/app_list/views/search_box_view.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "ui/app_list/views/search_box_view.h"
 
 #include <algorithm>
 
 #include "base/macros.h"
 #include "base/memory/ptr_util.h"
 #include "build/build_config.h"
 #include "ui/app_list/app_list_constants.h"
+#include "ui/app_list/app_list_features.h"
 #include "ui/app_list/app_list_model.h"
 #include "ui/app_list/app_list_switches.h"
 #include "ui/app_list/app_list_view_delegate.h"
 #include "ui/app_list/resources/grit/app_list_resources.h"
 #include "ui/app_list/search_box_model.h"
 #include "ui/app_list/speech_ui_model.h"
+#include "ui/app_list/views/app_list_view.h"
 #include "ui/app_list/views/contents_view.h"
 #include "ui/app_list/views/search_box_view_delegate.h"
 #include "ui/base/ime/text_input_flags.h"
 #include "ui/base/l10n/l10n_util.h"
 #include "ui/base/resource/resource_bundle.h"
 #include "ui/events/event.h"
 #include "ui/gfx/canvas.h"
 #include "ui/gfx/shadow_value.h"
 #include "ui/strings/grit/ui_strings.h"
 #include "ui/views/background.h"
 #include "ui/views/border.h"
 #include "ui/views/controls/button/image_button.h"
 #include "ui/views/controls/image_view.h"
 #include "ui/views/controls/textfield/textfield.h"
 #include "ui/views/layout/box_layout.h"
 #include "ui/views/layout/fill_layout.h"
 #include "ui/views/shadow_border.h"
+#include "ui/views/widget/widget.h"
 
 namespace app_list {
 
 namespace {
 
 const int kPadding = 16;
 const int kInnerPadding = 24;
 const int kPreferredWidth = 360;
+const int kPreferredWidthFullscreen = 544;
 const int kPreferredHeight = 48;
 
 const SkColor kHintTextColor = SkColorSetRGB(0xA0, 0xA0, 0xA0);
 
 const int kBackgroundBorderCornerRadius = 2;
+const int kBackgroundBorderCornerRadiusFullscreen = 20;
 
 // A background that paints a solid white rounded rect with a thin grey border.
 class SearchBoxBackground : public views::Background {
  public:
   SearchBoxBackground() {}
   ~SearchBoxBackground() override {}
 
  private:
   // views::Background overrides:
   void Paint(gfx::Canvas* canvas, views::View* view) const override {
     gfx::Rect bounds = view->GetContentsBounds();
 
     cc::PaintFlags flags;
     flags.setAntiAlias(true);
     flags.setColor(kSearchBoxBackground);
-    canvas->DrawRoundRect(bounds, kBackgroundBorderCornerRadius, flags);
+    canvas->DrawRoundRect(bounds,
+                          features::IsFullscreenAppListEnabled()

[vadimt, 2017/05/22 23:36:58]

Is Paint() called frequently enough to start worrying about the price of
features::IsFullscreenAppListEnabled()?

[newcomer, 2017/05/25 23:10:53]

Good question. I'm not sure but I'll ask around. In the meantime I've moved it
to a member variable that is checked on initialization.

[vadimt, 2017/05/26 01:27:56]

And make sure that a SearchBoxBackground instance is never shared by 2
consequential parameterized tests (with different values of
IsFullscreenAppListEnabled()).

[newcomer, 2017/05/26 23:20:20]

They aren't. SearchBoxBackground is created when a SearchBoxView is created.

+                              ? kBackgroundBorderCornerRadiusFullscreen
+                              : kBackgroundBorderCornerRadius,
+                          flags);
   }
 
   DISALLOW_COPY_AND_ASSIGN(SearchBoxBackground);
 };
 
 }  // namespace
 
 // To paint grey background on mic and back buttons
 class SearchBoxImageButton : public views::ImageButton {
  public:
@@ skipping 31 matching lines @@
   }
 
   const char* GetClassName() const override { return "SearchBoxImageButton"; }
 
   bool selected_;
 
   DISALLOW_COPY_AND_ASSIGN(SearchBoxImageButton);
 };
 
 SearchBoxView::SearchBoxView(SearchBoxViewDelegate* delegate,
-                             AppListViewDelegate* view_delegate)
+                             AppListViewDelegate* view_delegate )

[vadimt, 2017/05/22 23:36:58]

git cl format . to remove added space

[newcomer, 2017/05/25 23:10:53]

Done.

     : delegate_(delegate),
       view_delegate_(view_delegate),
       model_(NULL),
       content_container_(new views::View),
       back_button_(NULL),
       speech_button_(NULL),
       search_box_(new views::Textfield),
       contents_view_(NULL),
+      app_list_view_(),

[vadimt, 2017/05/22 23:36:58]

This leaves it uninitialized. Replace with '=nullptr' in header.

[newcomer, 2017/05/25 23:10:53]

The other pointers are set to NULL in the constructor, is this fine?

[vadimt, 2017/05/26 01:27:56]

Just old code. nullptr is a new way, and is my preference.

[newcomer, 2017/05/26 23:20:20]

It is now initialized as a constant pointer to the AppListView.

       focused_view_(FOCUS_SEARCH_BOX) {
   SetLayoutManager(new views::FillLayout);
   AddChildView(content_container_);
 
   SetShadow(GetShadowForZHeight(2));
   back_button_ = new SearchBoxImageButton(this);
   ui::ResourceBundle& rb = ui::ResourceBundle::GetSharedInstance();
   back_button_->SetImage(views::ImageButton::STATE_NORMAL,
                          rb.GetImageSkiaNamed(IDR_APP_LIST_FOLDER_BACK_NORMAL));
   back_button_->SetImageAlignment(views::ImageButton::ALIGN_CENTER,
@@ skipping 46 matching lines @@
 
 void SearchBoxView::ClearSearch() {
   search_box_->SetText(base::string16());
   view_delegate_->AutoLaunchCanceled();
   // Updates model and fires query changed manually because SetText() above
   // does not generate ContentsChanged() notification.
   UpdateModel();
   NotifyQueryChanged();
 }
 
+void SearchBoxView::SetAppListView(AppListView* app_list_view) {
+  app_list_view_ = app_list_view;
+}
+
 void SearchBoxView::SetShadow(const gfx::ShadowValue& shadow) {
   SetBorder(base::MakeUnique<views::ShadowBorder>(shadow));
   Layout();
 }
 
 gfx::Rect SearchBoxView::GetViewBoundsForSearchBoxContentsBounds(
     const gfx::Rect& rect) const {
   gfx::Rect view_bounds = rect;
   view_bounds.Inset(-GetInsets());
   return view_bounds;
@@ skipping 79 matching lines @@
     return;
 
   base::string16 back_button_label(l10n_util::GetStringUTF16(
       folder ? IDS_APP_LIST_FOLDER_CLOSE_FOLDER_ACCESSIBILE_NAME
              : IDS_APP_LIST_BACK));
   back_button_->SetAccessibleName(back_button_label);
   back_button_->SetTooltipText(back_button_label);
 }
 
 gfx::Size SearchBoxView::GetPreferredSize() const {
-  return gfx::Size(kPreferredWidth, kPreferredHeight);
+  return gfx::Size(features::IsFullscreenAppListEnabled()
+                       ? kPreferredWidthFullscreen
+                       : kPreferredWidth,
+                   kPreferredHeight);
 }
 
 bool SearchBoxView::OnMouseWheel(const ui::MouseWheelEvent& event) {
   if (contents_view_)
     return contents_view_->OnMouseWheel(event);
 
   return false;
 }
 
 void SearchBoxView::OnEnabledChanged() {
@@ skipping 17 matching lines @@
 void SearchBoxView::NotifyQueryChanged() {
   DCHECK(delegate_);
   delegate_->QueryChanged(this);
 }
 
 void SearchBoxView::ContentsChanged(views::Textfield* sender,
                                     const base::string16& new_contents) {
   UpdateModel();
   view_delegate_->AutoLaunchCanceled();
   NotifyQueryChanged();
+
+  if (features::IsFullscreenAppListEnabled() &&
+      !app_list_view_->IsFullscreen()) {
+    // If the app list is in the peeking state, switch it to fullscreen.
+    app_list_view_->ToFullscreen();
+  }
 }
 
 bool SearchBoxView::HandleKeyEvent(views::Textfield* sender,
                                    const ui::KeyEvent& key_event) {
   if (key_event.type() == ui::ET_KEY_PRESSED) {
     if (key_event.key_code() == ui::VKEY_TAB &&
         focused_view_ != FOCUS_CONTENTS_VIEW &&
         MoveTabFocus(key_event.IsShiftDown()))
       return true;
 
@@ skipping 95 matching lines @@
   NotifyQueryChanged();
 }
 
 void SearchBoxView::OnSpeechRecognitionStateChanged(
     SpeechRecognitionState new_state) {
   SpeechRecognitionButtonPropChanged();
   SchedulePaint();
 }
 
 }  // namespace app_list