mojo/services/dbus_echo/dbus_echo_service.cc - Issue 289873008: Mojo: Make overriding OnConnectionError optional

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: mojo/services/dbus_echo/dbus_echo_service.cc

Issue 289873008: Mojo: Make overriding OnConnectionError optional (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: rebase Created 6 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: mojo/services/dbus_echo/dbus_echo_service.cc

diff --git a/mojo/services/dbus_echo/dbus_echo_service.cc b/mojo/services/dbus_echo/dbus_echo_service.cc

index 0678339166613774040eff9a06ee747399f4c243..f9e476e735712eb0c43b76447fd097436604684d 100644

--- a/mojo/services/dbus_echo/dbus_echo_service.cc

+++ b/mojo/services/dbus_echo/dbus_echo_service.cc

@@ -21,8 +21,6 @@ class EchoServiceImpl : public mojo::InterfaceImpl<mojo::EchoService> {

EchoServiceImpl() {}

virtual ~EchoServiceImpl() {}

- virtual void OnConnectionError() OVERRIDE {}

protected:

virtual void Echo(

const mojo::String& in_to_echo,