Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(617)

Issue 289873002: Remove isCompositorFramePending plumbing (Closed)

Created:
6 years, 7 months ago by enne (OOO)
Modified:
6 years, 7 months ago
CC:
blink-reviews, jamesr, arv+blink, abarth-chromium, dglazkov+blink, gavinp+loader_chromium.org, Nate Chapin, watchdog-blink-watchlist_google.com, Inactive
Visibility:
Public.

Description

Remove isCompositorFramePending plumbing Originally added: https://codereview.chromium.org/139103009. This is only used for one test, and is somewhat a lie because WebTestProxy implements its own (very different) animate/composite scheduling. Removing this plumbing makes it possible to better clean up old non-composited paint logic inside of WebTestProxy. Due to changes elsewhere, this test no longer catches the original regression. The scheduleAnimate call inside of RenderLayerCompositor that was added in the original patch can be removed and the page still paints properly. In fact, all scheduleAnimate calls and calls to the page animator in RLC can be removed and the page still gets updated. The code in RenderLayerCompositor has changed drastically since m33, and if possible I'd like to remove this one-off plumbing that is no longer catching any regressions. TBR=abarth@chromium.org BUG=none Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=174200

Patch Set 1 #

Patch Set 2 : Expectation #

Patch Set 3 : Expectations for virtual suite #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -65 lines) Patch
M LayoutTests/TestExpectations View 1 2 1 chunk +3 lines, -0 lines 0 comments Download
M LayoutTests/compositing/layer-creation/should-invoke-deferred-compositing.html View 2 chunks +5 lines, -37 lines 0 comments Download
M Source/core/loader/EmptyClients.h View 1 chunk +0 lines, -2 lines 0 comments Download
M Source/core/page/ChromeClient.h View 1 chunk +0 lines, -2 lines 0 comments Download
M Source/core/testing/Internals.h View 1 chunk +0 lines, -2 lines 0 comments Download
M Source/core/testing/Internals.cpp View 1 chunk +0 lines, -10 lines 0 comments Download
M Source/core/testing/Internals.idl View 1 chunk +0 lines, -1 line 0 comments Download
M Source/web/ChromeClientImpl.h View 1 chunk +0 lines, -1 line 0 comments Download
M Source/web/ChromeClientImpl.cpp View 1 chunk +0 lines, -5 lines 0 comments Download
M public/web/WebWidgetClient.h View 1 chunk +0 lines, -5 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
enne (OOO)
6 years, 7 months ago (2014-05-14 22:51:26 UTC) #1
ojan
lgtm I agree. Exposing blink internals like this doesn't make sense for one-offs, as evidenced ...
6 years, 7 months ago (2014-05-14 23:03:22 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/enne@chromium.org/289873002/20001
6 years, 7 months ago (2014-05-14 23:04:04 UTC) #3
enne (OOO)
The CQ bit was unchecked by enne@chromium.org
6 years, 7 months ago (2014-05-15 00:15:38 UTC) #4
enne (OOO)
abarth: public/web OWNERS?
6 years, 7 months ago (2014-05-15 00:15:51 UTC) #5
enne (OOO)
TBRing abarth for public/web as this is just removing a function that no longer has ...
6 years, 7 months ago (2014-05-16 17:09:29 UTC) #6
enne (OOO)
The CQ bit was checked by enne@chromium.org
6 years, 7 months ago (2014-05-16 17:09:35 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/enne@chromium.org/289873002/40001
6 years, 7 months ago (2014-05-16 17:09:51 UTC) #8
commit-bot: I haz the power
Change committed as 174200
6 years, 7 months ago (2014-05-16 18:38:06 UTC) #9
chrishtr
6 years, 7 months ago (2014-05-19 16:37:04 UTC) #10
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698