components/sync/driver/sync_service_base.h - Issue 2898723003: [Sync] Migrate SyncInternalsMessageHandler off CallJavascriptFunctionUnsafe.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/sync/driver/sync_service_base.h

Issue 2898723003: [Sync] Migrate SyncInternalsMessageHandler off CallJavascriptFunctionUnsafe. (Closed)

Patch Set: Updates for dbeam and fixing windows browser test. Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: components/sync/driver/sync_service_base.h

diff --git a/components/sync/driver/sync_service_base.h b/components/sync/driver/sync_service_base.h

index fb902b0b75598d16564e491f61d5ec97fdb8d4b9..a0121961a0669fdd6f824025e554a7817d13a679 100644

--- a/components/sync/driver/sync_service_base.h

+++ b/components/sync/driver/sync_service_base.h

@@ -47,6 +47,7 @@ class SyncServiceBase : public SyncService, public SyncEngineHost {

void AddObserver(SyncServiceObserver* observer) override;

void RemoveObserver(SyncServiceObserver* observer) override;

bool HasObserver(const SyncServiceObserver* observer) const override;

+ SigninManagerBase* signin() const override;

// Given base path (path to profile) formats path to "Sync Data" folder where

// sync engine stores directory database.