chrome/browser/sync/profile_sync_service_android.cc - Issue 2898723003: [Sync] Migrate SyncInternalsMessageHandler off CallJavascriptFunctionUnsafe.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/sync/profile_sync_service_android.cc

Issue 2898723003: [Sync] Migrate SyncInternalsMessageHandler off CallJavascriptFunctionUnsafe. (Closed)

Patch Set: Updates for dbeam and fixing windows browser test. Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments.

Jump to:

Index: chrome/browser/sync/profile_sync_service_android.cc

diff --git a/chrome/browser/sync/profile_sync_service_android.cc b/chrome/browser/sync/profile_sync_service_android.cc

index 48eb13a0da8e4dfdc8346cf2a7ca4fa666dfcd3a..61be62029803003c47228938fba1860d0c9c3a0b 100644

--- a/chrome/browser/sync/profile_sync_service_android.cc

+++ b/chrome/browser/sync/profile_sync_service_android.cc

@@ -467,8 +467,8 @@ ScopedJavaLocalRef<jstring> ProfileSyncServiceAndroid::GetAboutInfoForTest(

DCHECK_CURRENTLY_ON(BrowserThread::UI);

std::unique_ptr<base::DictionaryValue> about_info =

- syncer::sync_ui_util::ConstructAboutInformation(

- sync_service_, sync_service_->signin(), chrome::GetChannel());

+ syncer::sync_ui_util::ConstructAboutInformation(sync_service_,

+ chrome::GetChannel());

std::string about_info_json;

base::JSONWriter::Write(*about_info, &about_info_json);