components/sync/driver/about_sync_util_unittest.cc - Issue 2898723003: [Sync] Migrate SyncInternalsMessageHandler off CallJavascriptFunctionUnsafe.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/sync/driver/about_sync_util_unittest.cc

Issue 2898723003: [Sync] Migrate SyncInternalsMessageHandler off CallJavascriptFunctionUnsafe. (Closed)

Patch Set: More updates for dbeam. Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: components/sync/driver/about_sync_util_unittest.cc

diff --git a/components/sync/driver/about_sync_util_unittest.cc b/components/sync/driver/about_sync_util_unittest.cc

index 7a6effb2467c40d8d5206e5b624347ff7c722a55..1ad4d4e4ffbcd18f8ac8f2ce74a0caa2c9af9cc4 100644

--- a/components/sync/driver/about_sync_util_unittest.cc

+++ b/components/sync/driver/about_sync_util_unittest.cc

@@ -38,8 +38,8 @@ class SyncServiceMock : public FakeSyncService {

TEST(SyncUIUtilTestAbout, ConstructAboutInformationWithUnrecoverableErrorTest) {

SyncServiceMock service;

- std::unique_ptr<base::DictionaryValue> strings(ConstructAboutInformation(

- &service, nullptr, version_info::Channel::UNKNOWN));

+ std::unique_ptr<base::DictionaryValue> strings(

+ ConstructAboutInformation(&service, version_info::Channel::UNKNOWN));

EXPECT_TRUE(strings->HasKey("unrecoverable_error_detected"));

}