chrome/browser/sync/test/integration/profile_sync_service_harness.cc - Issue 2898723003: [Sync] Migrate SyncInternalsMessageHandler off CallJavascriptFunctionUnsafe.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/sync/test/integration/profile_sync_service_harness.cc

Issue 2898723003: [Sync] Migrate SyncInternalsMessageHandler off CallJavascriptFunctionUnsafe. (Closed)

Patch Set: More updates for dbeam. Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/sync/profile_sync_service_android.cc ('k') | chrome/browser/ui/webui/sync_internals_message_handler.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/sync/test/integration/profile_sync_service_harness.cc

diff --git a/chrome/browser/sync/test/integration/profile_sync_service_harness.cc b/chrome/browser/sync/test/integration/profile_sync_service_harness.cc

index b186e7f7b1d9f65d0298dcb88212634924e12ff4..411beeb2b90c81fe1374ebfa1a87eda007396648 100644

--- a/chrome/browser/sync/test/integration/profile_sync_service_harness.cc

+++ b/chrome/browser/sync/test/integration/profile_sync_service_harness.cc

@@ -543,8 +543,8 @@ bool ProfileSyncServiceHarness::IsTypePreferred(syncer::ModelType type) {

std::string ProfileSyncServiceHarness::GetServiceStatus() {

std::unique_ptr<base::DictionaryValue> value(

- syncer::sync_ui_util::ConstructAboutInformation(

- service(), service()->signin(), chrome::GetChannel()));

+ syncer::sync_ui_util::ConstructAboutInformation(service(),

+ chrome::GetChannel()));

std::string service_status;

base::JSONWriter::WriteWithOptions(

*value, base::JSONWriter::OPTIONS_PRETTY_PRINT, &service_status);

« no previous file with comments | « chrome/browser/sync/profile_sync_service_android.cc ('k') | chrome/browser/ui/webui/sync_internals_message_handler.h » ('j') | no next file with comments »