Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(56)

Issue 2898693002: Make Equality.hash accept null as an argument. (Closed)

Created:
3 years, 7 months ago by Lasse Reichstein Nielsen
Modified:
3 years, 7 months ago
Reviewers:
floitsch
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Make Equality.hash accept null as an argument. This just makes it easier to use the equality directly on a nullable type. The `isValidKey` check still say no for `null`. R=floitsch@google.com Committed: https://github.com/dart-lang/collection/commit/c572a1e908a41ee4c9fc98880de8c4df28ea949c Committed: https://github.com/dart-lang/collection/commit/4c6d40c86c20f02ed6f73412f2be9141ae6a9553

Patch Set 1 #

Patch Set 2 : Fix typo. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M lib/src/equality.dart View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (3 generated)
Lasse Reichstein Nielsen
3 years, 7 months ago (2017-05-22 12:07:55 UTC) #2
floitsch
LGTM.
3 years, 7 months ago (2017-05-22 12:09:40 UTC) #3
Lasse Reichstein Nielsen
Committed patchset #1 (id:1) manually as c572a1e908a41ee4c9fc98880de8c4df28ea949c (presubmit successful).
3 years, 7 months ago (2017-05-22 12:32:47 UTC) #5
Lasse Reichstein Nielsen
3 years, 7 months ago (2017-05-22 12:38:41 UTC) #7
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
4c6d40c86c20f02ed6f73412f2be9141ae6a9553 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698