Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(728)

Unified Diff: chrome/browser/chromeos/policy/proto/chrome_device_policy.proto

Issue 2898683002: Default unspecified value added to enum in proto (Closed)
Patch Set: Merged Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/chromeos/policy/proto/chrome_device_policy.proto
diff --git a/chrome/browser/chromeos/policy/proto/chrome_device_policy.proto b/chrome/browser/chromeos/policy/proto/chrome_device_policy.proto
index 2330699f75581f3cf12bd73f3904791b10c27b75..cfdeca2b66678312982878cea8a454639f7e9850 100644
--- a/chrome/browser/chromeos/policy/proto/chrome_device_policy.proto
+++ b/chrome/browser/chromeos/policy/proto/chrome_device_policy.proto
@@ -783,10 +783,12 @@ message DeviceWallpaperImageProto {
// the device used ecryptfs in the past.
message DeviceEcryptfsMigrationStrategyProto {
enum MigrationStrategy {
+ // Default value, unspecified.
+ MIGRATION_STRATEGY_UNSPECIFIED = 0;
Andrew T Wilson (Slow) 2017/05/22 12:30:56 I'm not sure that's what we want. What behavior do
bartfab (slow) 2017/05/22 13:23:47 We (the client) do not want or need an UNSET value
igorcov 2017/05/22 17:20:32 Changed to UNSET. Thanks for explanations.
Thiemo Nagel 2017/05/23 09:27:31 Imho this is just enforcing proto best practices (
// ARC is not allowed, no data migration needed.
- DISALLOW_ARC = 0;
+ DISALLOW_ARC = 1;
// The data migration is allowed, opening the possibility to use ARC.
- ALLOW_MIGRATION = 1;
+ ALLOW_MIGRATION = 2;
};
optional MigrationStrategy migration_strategy = 1;
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698