Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(382)

Issue 289863008: Initialize Talk thread pointer during ChromotingHost initialization. (Closed)

Created:
6 years, 7 months ago by Wez
Modified:
6 years, 7 months ago
Reviewers:
Sergey Ulanov
CC:
chromium-reviews, chromoting-reviews_chromium.org
Visibility:
Public.

Description

Initialize Talk thread pointer during ChromotingHost initialization. Without this the host will crash as soon as the BasicNetworkManager is started, i.e. when a client connection is first received, due to talk_base::Thread::current() being NULL. BUG=375564 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=272045

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -0 lines) Patch
M remoting/host/DEPS View 1 chunk +1 line, -0 lines 0 comments Download
M remoting/host/chromoting_host.cc View 2 chunks +3 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
Wez
6 years, 7 months ago (2014-05-21 01:25:52 UTC) #1
Sergey Ulanov
LGTM Thanks for fixing it!
6 years, 7 months ago (2014-05-21 01:28:37 UTC) #2
Wez
On 2014/05/21 01:28:37, Sergey Ulanov wrote: > LGTM > Thanks for fixing it! NP - ...
6 years, 7 months ago (2014-05-21 01:31:01 UTC) #3
Wez
The CQ bit was checked by wez@chromium.org
6 years, 7 months ago (2014-05-21 01:31:06 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/wez@chromium.org/289863008/1
6 years, 7 months ago (2014-05-21 01:34:16 UTC) #5
Wez
The CQ bit was unchecked by wez@chromium.org
6 years, 7 months ago (2014-05-21 17:36:31 UTC) #6
Wez
The CQ bit was checked by wez@chromium.org
6 years, 7 months ago (2014-05-21 17:36:39 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/wez@chromium.org/289863008/1
6 years, 7 months ago (2014-05-21 19:57:30 UTC) #8
commit-bot: I haz the power
6 years, 7 months ago (2014-05-22 01:35:48 UTC) #9
Message was sent while issue was closed.
Change committed as 272045

Powered by Google App Engine
This is Rietveld 408576698