base/message_loop/timer_slack.h - Issue 289863005: [Mac] Maximise timer slack for background tabs

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: base/message_loop/timer_slack.h

Issue 289863005: [Mac] Maximise timer slack for background tabs (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Initial review Created 6 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
(Empty)
	1 // Copyright 2014 The Chromium Authors. All rights reserved.

	2 // Use of this source code is governed by a BSD-style license that can be

	3 // found in the LICENSE file.

	4

	5 #ifndef BASE_MESSAGE_LOOP_TIMER_SLACK_H_

	6 #define BASE_MESSAGE_LOOP_TIMER_SLACK_H_

	7

	8 #include "base/base_export.h"

	9

	10 namespace base {

	11

	12 enum TimerSlack {

	13 TIMER_SLACK_NONE,

	14 TIMER_SLACK_MAXIMUM

	15 };

	16

	17 // Sets the global timer slack number for this process.
	tonyg 2014/05/20 14:14:52 Why is this process wide? I thought that we could Why is this process wide? I thought that we could get per-thread everywhere and per-timer some places. So a good starter implementation seems to be per-thread only (since we can do that everywhere). Would it be possible to do that on the MessageLoop instance itself instead of as a global static setting like this? It guarantees a max of one MessageLoop instance per thread.
	18 void SetTimerSlack(TimerSlack timer_slack) BASE_EXPORT;

	19

	20 TimerSlack GetTimerSlack();

	21

	22 } // namespace base

	23

	24 #endif // BASE_MESSAGE_LOOP_TIMER_SLACK_H_

OLD	NEW