Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3158)

Unified Diff: android_webview/browser/aw_safe_browsing_ui_manager.h

Issue 2898593002: WebView: choose loud vs. quiet interstitial (Closed)
Patch Set: Rebase and fix patch conflict Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: android_webview/browser/aw_safe_browsing_ui_manager.h
diff --git a/android_webview/browser/aw_safe_browsing_ui_manager.h b/android_webview/browser/aw_safe_browsing_ui_manager.h
index f1fc5357c6b6864d9ad748c4874fceace3a4b902..545f2cdfcc6574f6c1efabc973d6c4a12a1f5c4d 100644
--- a/android_webview/browser/aw_safe_browsing_ui_manager.h
+++ b/android_webview/browser/aw_safe_browsing_ui_manager.h
@@ -20,8 +20,14 @@ class AwSafeBrowsingUIManager : public safe_browsing::BaseUIManager {
public:
static UIManagerClient* FromWebContents(content::WebContents* web_contents);
- // Whether this web contents can show an interstitial
+ // Whether this web contents can show a loud interstitial
virtual bool CanShowBigInterstitial() = 0;
+
+ // Whether this web contents can show any sort of interstitial
+ virtual bool CanShowInterstitial() = 0;
+
+ // Whether this web contents extends outside of the application window
+ virtual bool ExtendsOutOfWindow() = 0;
};
// Construction needs to happen on the UI thread.
@@ -29,6 +35,12 @@ class AwSafeBrowsingUIManager : public safe_browsing::BaseUIManager {
void DisplayBlockingPage(const UnsafeResource& resource) override;
+ // Indicates if we should use a loud or quiet error page
+ bool IsLoud(const UnsafeResource& resource) const;
+
+ // Indicates if the WebView extends off the screen or not
+ bool IsGiant(const UnsafeResource& resource) const;
+
protected:
~AwSafeBrowsingUIManager() override;

Powered by Google App Engine
This is Rietveld 408576698