Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(275)

Unified Diff: components/safe_browsing/base_blocking_page.h

Issue 2898593002: WebView: choose loud vs. quiet interstitial (Closed)
Patch Set: Rebase, fix merge conflicts Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « android_webview/ui/grit_strings_whitelist.txt ('k') | components/safe_browsing/base_blocking_page.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/safe_browsing/base_blocking_page.h
diff --git a/components/safe_browsing/base_blocking_page.h b/components/safe_browsing/base_blocking_page.h
index 66c34e76dc0805bf8e461ebab59f3154cff13b04..d4a8c674cddb10316f7f2926e8c502dffb439925 100644
--- a/components/safe_browsing/base_blocking_page.h
+++ b/components/safe_browsing/base_blocking_page.h
@@ -117,6 +117,10 @@ class BaseBlockingPage
const UnsafeResourceList& unsafe_resources,
BaseUIManager* ui_manager);
+ int GetHTMLTemplateId() override;
+
+ void set_sb_error_ui(std::unique_ptr<BaseSafeBrowsingErrorUI> sb_error_ui);
+
private:
// For reporting back user actions.
BaseUIManager* ui_manager_;
@@ -131,9 +135,6 @@ class BaseBlockingPage
// The list of unsafe resources this page is warning about.
UnsafeResourceList unsafe_resources_;
- // For displaying safe browsing interstitial.
- std::unique_ptr<BaseSafeBrowsingErrorUI> sb_error_ui_;
-
// Indicate whether user has proceeded this blocking page.
bool proceeded_;
@@ -143,6 +144,9 @@ class BaseBlockingPage
// milliseconds), in order to get data from the blocked resource itself.
int64_t threat_details_proceed_delay_ms_;
+ // For displaying safe browsing interstitial.
+ std::unique_ptr<BaseSafeBrowsingErrorUI> sb_error_ui_;
+
DISALLOW_COPY_AND_ASSIGN(BaseBlockingPage);
};
« no previous file with comments | « android_webview/ui/grit_strings_whitelist.txt ('k') | components/safe_browsing/base_blocking_page.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698