Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8)

Unified Diff: android_webview/browser/aw_safe_browsing_blocking_page.h

Issue 2898593002: WebView: choose loud vs. quiet interstitial (Closed)
Patch Set: Rebase, fix merge conflicts Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « android_webview/browser/aw_contents.cc ('k') | android_webview/browser/aw_safe_browsing_blocking_page.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: android_webview/browser/aw_safe_browsing_blocking_page.h
diff --git a/android_webview/browser/aw_safe_browsing_blocking_page.h b/android_webview/browser/aw_safe_browsing_blocking_page.h
index 6751d596e2155eefe8184988e06ed3939d98e7c2..8b597bdbf81e9963b58ff1827ab2d19c881e7bee 100644
--- a/android_webview/browser/aw_safe_browsing_blocking_page.h
+++ b/android_webview/browser/aw_safe_browsing_blocking_page.h
@@ -24,6 +24,11 @@ class AwSafeBrowsingBlockingPage : public safe_browsing::BaseBlockingPage {
const UnsafeResource& unsafe_resource);
protected:
+ // Used to specify which BaseSafeBrowsingErrorUI to instantiate, and
+ // parameters they require.
+ // GENERATED_JAVA_ENUM_PACKAGE: org.chromium.android_webview
+ enum class ErrorUiType { LOUD, QUIET_SMALL, QUIET_GIANT };
+
// Don't instantiate this class directly, use ShowBlockingPage instead.
AwSafeBrowsingBlockingPage(
AwSafeBrowsingUIManager* ui_manager,
@@ -33,7 +38,8 @@ class AwSafeBrowsingBlockingPage : public safe_browsing::BaseBlockingPage {
std::unique_ptr<
security_interstitials::SecurityInterstitialControllerClient>
controller_client,
- const BaseSafeBrowsingErrorUI::SBErrorDisplayOptions& display_options);
+ const BaseSafeBrowsingErrorUI::SBErrorDisplayOptions& display_options,
+ ErrorUiType errorUiType);
};
} // namespace android_webview
« no previous file with comments | « android_webview/browser/aw_contents.cc ('k') | android_webview/browser/aw_safe_browsing_blocking_page.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698