Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1126)

Unified Diff: net/url_request/url_request_http_job.cc

Issue 2898573002: Refactor client cert private key handling. (Closed)
Patch Set: removed no longer needed forward declaration Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « net/url_request/url_request_http_job.h ('k') | net/url_request/url_request_job.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/url_request/url_request_http_job.cc
diff --git a/net/url_request/url_request_http_job.cc b/net/url_request/url_request_http_job.cc
index 5854617532ae87e83444639e56b36b178bcbe02d..b34fbd5157d27740a789fa471bf4b9ef748fee18 100644
--- a/net/url_request/url_request_http_job.cc
+++ b/net/url_request/url_request_http_job.cc
@@ -1264,8 +1264,8 @@ void URLRequestHttpJob::CancelAuth() {
}
void URLRequestHttpJob::ContinueWithCertificate(
- X509Certificate* client_cert,
- SSLPrivateKey* client_private_key) {
+ scoped_refptr<X509Certificate> client_cert,
+ scoped_refptr<SSLPrivateKey> client_private_key) {
DCHECK(transaction_.get());
DCHECK(!response_info_) << "should not have a response yet";
@@ -1274,7 +1274,7 @@ void URLRequestHttpJob::ContinueWithCertificate(
ResetTimer();
int rv = transaction_->RestartWithCertificate(
- client_cert, client_private_key,
+ std::move(client_cert), std::move(client_private_key),
base::Bind(&URLRequestHttpJob::OnStartCompleted, base::Unretained(this)));
if (rv == ERR_IO_PENDING)
return;
« no previous file with comments | « net/url_request/url_request_http_job.h ('k') | net/url_request/url_request_job.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698