Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1923)

Unified Diff: net/ssl/client_cert_store_nss.h

Issue 2898573002: Refactor client cert private key handling. (Closed)
Patch Set: removed no longer needed forward declaration Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « net/ssl/client_cert_store_mac_unittest.cc ('k') | net/ssl/client_cert_store_nss.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/ssl/client_cert_store_nss.h
diff --git a/net/ssl/client_cert_store_nss.h b/net/ssl/client_cert_store_nss.h
index d49d50f6a43298eaac20d85756a637fdf0647654..3f05267843ff96c06768b68486b71e735c9acccd 100644
--- a/net/ssl/client_cert_store_nss.h
+++ b/net/ssl/client_cert_store_nss.h
@@ -35,26 +35,24 @@ class NET_EXPORT ClientCertStoreNSS : public ClientCertStore {
void GetClientCerts(const SSLCertRequestInfo& cert_request_info,
const ClientCertListCallback& callback) override;
- // Examines the certificates in |certs| to find all certificates that match
- // the client certificate request in |request|, storing the matching
- // certificates in |filtered_certs|. Any previous content of |filtered_certs|
- // will be removed.
+ // Examines the certificates in |identities| to find all certificates that
+ // match the client certificate request in |request|, removing any that don't.
+ // The remaining certs will be updated to include intermediates.
// Must be called from a worker thread.
- static void FilterCertsOnWorkerThread(const CertificateList& certs,
- const SSLCertRequestInfo& request,
- CertificateList* filtered_certs);
+ static void FilterCertsOnWorkerThread(ClientCertIdentityList* identities,
+ const SSLCertRequestInfo& request);
// Retrieves all client certificates that are stored by NSS and adds them to
- // |certs|. |password_delegate| is used to unlock slots if required.
+ // |identities|. |password_delegate| is used to unlock slots if required.
// Must be called from a worker thread.
static void GetPlatformCertsOnWorkerThread(
- std::unique_ptr<crypto::CryptoModuleBlockingPasswordDelegate>
+ scoped_refptr<crypto::CryptoModuleBlockingPasswordDelegate>
password_delegate,
- net::CertificateList* certs);
+ ClientCertIdentityList* identities);
private:
- CertificateList GetAndFilterCertsOnWorkerThread(
- std::unique_ptr<crypto::CryptoModuleBlockingPasswordDelegate>
+ ClientCertIdentityList GetAndFilterCertsOnWorkerThread(
+ scoped_refptr<crypto::CryptoModuleBlockingPasswordDelegate>
password_delegate,
const SSLCertRequestInfo* request);
« no previous file with comments | « net/ssl/client_cert_store_mac_unittest.cc ('k') | net/ssl/client_cert_store_nss.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698